qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: joy zhao <yanhwizhao@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] set vidmode in linux kernel header when boot x86 using qemu bootloader
Date: Tue, 26 May 2009 15:26:48 +0100	[thread overview]
Message-ID: <1243348008.19124.23.camel@blaa> (raw)
In-Reply-To: <162800e10905260322r39594e35y4fd7f7afb52ef29@mail.gmail.com>

On Tue, 2009-05-26 at 18:22 +0800, joy zhao wrote:
> hi,
> I made a patch to have qemu parse vga field in kernel command line and
> set the vid_mode field of real-mode kernel header.
> This patch is necessary because vga is one of the special command line
> options that should be parsed in bootloader, as in linux kernel
> Documentation/x86/i386/boot.txt. After bootloader write the passed vga
> value into the vid_mode field of linux real-mode kernel header, this
> vid_mode will be handled by linux/x86/boot/video.c in linux kernel to
> select vesa graphics mode, and only in this mode can vesafb be
> registered(in vesafb_probe()).
> So, if we decide to launch linux directly from qemu command line as
> "qemu -kernel ... -initrd... -append "..." ", (use qemu bootloader)
> and use vesafb as framebuffer driver, this patch to qemu is required,
> otherwise, the screen should just blank since the vesafb fails to
> register itself.

FWIW, I agree we do need this - see also:

  https://bugzilla.redhat.com/501935
    qemu-kvm -kernel should parse "vga=" cmdline option

Cheers,
Mark.

      parent reply	other threads:[~2009-05-26 14:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26 10:22 [Qemu-devel] [PATCH] set vidmode in linux kernel header when boot x86 using qemu bootloader joy zhao
2009-05-26 13:29 ` Anthony Liguori
2009-05-27  6:01   ` joy zhao
2009-05-26 14:26 ` Mark McLoughlin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243348008.19124.23.camel@blaa \
    --to=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yanhwizhao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).