qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH 0/4] Split qcow2 driver
Date: Thu, 28 May 2009 16:07:03 +0200	[thread overview]
Message-ID: <1243519627-525-1-git-send-email-kwolf@redhat.com> (raw)

The current qcow2 code is a monster of 3000 lines of code. This is hardly
manageable and doesn't exactly improve the driver's structure.

This patch series tries to split the driver in smaller modules. It doesn't
contain changes to functionality or structure, especially the latter might come
later as this series makes it much clearer what the internal interfaces used by
the qcow2 driver actually are.

The first three patches mainly move code around. They also build up a qcow2.h
header file which contains the common structs and functions used by several
modules. Some functions need to become global to keep things compilable.

The fourth patch cleans up the global namespace by adding a qcow2_ prefix to
all of the new global functions introduced by the first patches.

Kevin Wolf (4):
  qcow2: Split out refcount handling
  qcow2: Split out guest cluster functions
  qcow2: Split out snapshot functions
  qcow2: Rename global functions

 Makefile               |    4 +-
 block/qcow2-cluster.c  |  755 ++++++++++++++++++
 block/qcow2-refcount.c |  836 +++++++++++++++++++
 block/qcow2-snapshot.c |  405 ++++++++++
 block/qcow2.c          | 2081 +-----------------------------------------------
 block/qcow2.h          |  203 +++++
 6 files changed, 2233 insertions(+), 2051 deletions(-)
 create mode 100644 block/qcow2-cluster.c
 create mode 100644 block/qcow2-refcount.c
 create mode 100644 block/qcow2-snapshot.c
 create mode 100644 block/qcow2.h

             reply	other threads:[~2009-05-28 14:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28 14:07 Kevin Wolf [this message]
2009-05-28 14:07 ` [Qemu-devel] [PATCH 1/4] qcow2: Split out refcount handling Kevin Wolf
2009-05-28 14:07 ` [Qemu-devel] [PATCH 2/4] qcow2: Split out guest cluster functions Kevin Wolf
2009-05-28 14:07 ` [Qemu-devel] [PATCH 3/4] qcow2: Split out snapshot functions Kevin Wolf
2009-05-28 14:07 ` [Qemu-devel] [PATCH 4/4] qcow2: Rename global functions Kevin Wolf
2009-05-28 14:39 ` [Qemu-devel] [PATCH 0/4] Split qcow2 driver Anthony Liguori
2009-05-28 14:56   ` Kevin Wolf
2009-05-28 15:18     ` Anthony Liguori
2009-05-28 15:11   ` Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243519627-525-1-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).