From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M9hCK-00044M-N5
	for qemu-devel@nongnu.org; Thu, 28 May 2009 11:07:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M9hCE-0003yN-ES
	for qemu-devel@nongnu.org; Thu, 28 May 2009 11:07:10 -0400
Received: from [199.232.76.173] (port=44313 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M9hCE-0003xx-3R
	for qemu-devel@nongnu.org; Thu, 28 May 2009 11:07:06 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48272)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1M9hCD-0005rt-GT
	for qemu-devel@nongnu.org; Thu, 28 May 2009 11:07:05 -0400
Subject: Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and
	bootp parameters and -net channel
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <20090508103418.6080.96654.stgit@mchn012c.ww002.siemens.net>
References: <20090508103416.6080.44298.stgit@mchn012c.ww002.siemens.net>
	<20090508103418.6080.96654.stgit@mchn012c.ww002.siemens.net>
Content-Type: text/plain
Date: Thu, 28 May 2009 16:07:01 +0100
Message-Id: <1243523221.4046.195.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org

On Fri, 2009-05-08 at 12:34 +0200, Jan Kiszka wrote:
> So far a couple of slirp-related parameters were expressed via
> stand-alone command line options. This it inconsistent and unintuitive.
> Moreover, it prevents both dynamically reconfigured (host_net_add/
> delete) and multi-instance slirp.
> 
> This patch refactors the configuration by turning -smb, -redir, -tftp
> and -bootp as well as -net channel into options of "-net user". The old
> stand-alone command line options are still processed, but no longer
> advertised. This allows smooth migration of management applications to
> to the new syntax and also the extension of that syntax later in this
> series.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
...
> diff --git a/slirp/main.h b/slirp/main.h
> index ed51385..537c145 100644
> --- a/slirp/main.h
> +++ b/slirp/main.h
> @@ -46,6 +46,8 @@ extern int tcp_keepintvl;
>  extern uint8_t client_ethaddr[6];
>  extern const char *slirp_special_ip;
>  extern int slirp_restrict;
> +extern char tftp_prefix[PATH_MAX];
> +extern char bootp_filename[PATH_MAX];

This wouldn't build for me without including limits.h here

Cheers,
Mark.