From: Alex Williamson <alex.williamson@hp.com>
To: Beth Kon <eak@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Add/Fix command-line checks for smbios options
Date: Thu, 28 May 2009 12:02:03 -0600 [thread overview]
Message-ID: <1243533723.25164.50.camel@bling> (raw)
In-Reply-To: <1243533236-27813-1-git-send-email-eak@us.ibm.com>
On Thu, 2009-05-28 at 13:53 -0400, Beth Kon wrote:
> - One type 4 table is required per cpu. Add a check for this.
> - Fix check for smbios file.
>
> Signed-off-by: Beth Kon <eak@us.ibm.com>
> --
>
> diff --git a/hw/smbios.c b/hw/smbios.c
> index ced90ce..2bc5c67 100644
> --- a/hw/smbios.c
> +++ b/hw/smbios.c
> @@ -40,9 +40,19 @@ struct smbios_table {
>
> static uint8_t *smbios_entries;
> static size_t smbios_entries_len;
> +static int smbios_type4_count = 0;
> +
> +void smbios_validate_table(void) {
static?
> + if (smbios_type4_count && smbios_type4_count != smp_cpus) {
> + fprintf(stderr,
> + "Number of SMBIOS Type 4 tables must match cpu count.\n");
extra space.
Looks ok otherwise. Thanks,
Alex
prev parent reply other threads:[~2009-05-28 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 17:53 [Qemu-devel] [PATCH] Add/Fix command-line checks for smbios options Beth Kon
2009-05-28 18:02 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243533723.25164.50.camel@bling \
--to=alex.williamson@hp.com \
--cc=eak@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).