From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MARoG-0005o5-MT
	for qemu-devel@nongnu.org; Sat, 30 May 2009 12:53:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MARoC-0005mC-5o
	for qemu-devel@nongnu.org; Sat, 30 May 2009 12:53:28 -0400
Received: from [199.232.76.173] (port=42263 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MARoC-0005m1-37
	for qemu-devel@nongnu.org; Sat, 30 May 2009 12:53:24 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:54957)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Laurent@vivier.eu>) id 1MARoB-0002ri-Eq
	for qemu-devel@nongnu.org; Sat, 30 May 2009 12:53:23 -0400
Subject: Re: [Qemu-devel] Re: [PATCH 17/17] m68k: add cas
From: Laurent Vivier <Laurent@vivier.eu>
In-Reply-To: <m2zlcuwvbs.fsf@igel.home>
References: <1243636921-23054-1-git-send-email-laurent@vivier.eu>
	<1243636921-23054-2-git-send-email-laurent@vivier.eu>
	<1243636921-23054-3-git-send-email-laurent@vivier.eu>
	<1243636921-23054-4-git-send-email-laurent@vivier.eu>
	<1243636921-23054-5-git-send-email-laurent@vivier.eu>
	<1243636921-23054-6-git-send-email-laurent@vivier.eu>
	<1243636921-23054-7-git-send-email-laurent@vivier.eu>
	<1243636921-23054-8-git-send-email-laurent@vivier.eu>
	<1243636921-23054-9-git-send-email-laurent@vivier.eu>
	<1243636921-23054-10-git-send-email-laurent@vivier.eu>
	<1243636921-23054-11-git-send-email-laurent@vivier.eu>
	<1243636921-23054-12-git-send-email-laurent@vivier.eu>
	<1243636921-23054-13-git-send-email-laurent@vivier.eu>
	<1243636921-23054-14-git-send-email-laurent@vivier.eu>
	<1243636921-23054-15-git-send-email-laurent@vivier.eu>
	<1243636921-23054-16-git-send-email-laurent@vivier.eu>
	<1243636921-23054-17-git-send-email-laurent@vivier.eu>
	<1243636921-23054-18-git-send-email-laurent@vivier.eu>
	<m2zlcuwvbs.fsf@igel.home>
Content-Type: text/plain; charset=utf-8
Date: Sat, 30 May 2009 18:53:17 +0200
Message-Id: <1243702397.5939.1.camel@Quad>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: qemu-devel@nongnu.org

Le samedi 30 mai 2009 =C3=A0 15:53 +0200, Andreas Schwab a =C3=A9crit :
> Laurent Vivier <laurent@vivier.eu> writes:
>=20
> > +    cmp =3D DREG(ext, 0);
> > +    update =3D DREG(ext, 6);
> > +    tmp =3D gen_load(s, opsize, addr, 0);
> > +    dest =3D tcg_temp_local_new();
> > +    tcg_gen_mov_i32(dest, tmp);
> > +
> > +    res =3D tcg_temp_new();
> > +    tcg_gen_sub_i32(res, dest, cmp);
> > +    gen_logic_cc(s, res);
> > +
> > +    l1 =3D gen_new_label();
> > +    l2 =3D gen_new_label();
> > +
> > +    gen_jmpcc(s, 6 /* !Z */, l1);
> > +    gen_store(s, opsize, addr, update);
>=20
> This has a bug: addr is used around a jump.
>=20

I agree, thank you.
(I didn't read tcg/README correctly...)

Laurent