From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MAWg5-00039r-Tl
	for qemu-devel@nongnu.org; Sat, 30 May 2009 18:05:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MAWfz-00039C-QK
	for qemu-devel@nongnu.org; Sat, 30 May 2009 18:05:20 -0400
Received: from [199.232.76.173] (port=56927 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MAWfz-000397-Mv
	for qemu-devel@nongnu.org; Sat, 30 May 2009 18:05:15 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:65308)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Laurent@vivier.eu>) id 1MAWfz-00060C-31
	for qemu-devel@nongnu.org; Sat, 30 May 2009 18:05:15 -0400
From: Laurent Vivier <Laurent@vivier.eu>
In-Reply-To: <m2iqjiw8su.fsf@igel.home>
References: <1243636921-23054-1-git-send-email-laurent@vivier.eu>
	<1243636921-23054-2-git-send-email-laurent@vivier.eu>
	<1243636921-23054-3-git-send-email-laurent@vivier.eu>
	<1243636921-23054-4-git-send-email-laurent@vivier.eu>
	<1243636921-23054-5-git-send-email-laurent@vivier.eu>
	<1243636921-23054-6-git-send-email-laurent@vivier.eu>
	<1243636921-23054-7-git-send-email-laurent@vivier.eu>
	<1243636921-23054-8-git-send-email-laurent@vivier.eu>
	<m2iqjiw8su.fsf@igel.home>
Content-Type: text/plain; charset=utf-8
Date: Sun, 31 May 2009 00:05:12 +0200
Message-Id: <1243721112.5939.3.camel@Quad>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 07/17] m68k: add DBcc instruction.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: qemu-devel@nongnu.org

Le dimanche 31 mai 2009 =C3=A0 00:00 +0200, Andreas Schwab a =C3=A9crit :
> Laurent Vivier <laurent@vivier.eu> writes:
>=20
> > +    tmp =3D tcg_temp_new();
> > +    tcg_gen_ext16s_i32(tmp, reg);
> > +    tcg_gen_addi_i32(tmp, tmp, -1);
> > +    gen_partset_reg(OS_WORD, reg, tmp);
> > +    tcg_gen_brcondi_i32(TCG_COND_EQ, tmp, 0, l1);
>=20
> The counter needs to be compared with -1, not 0.

Yes, "ls -l" works better, now.

Laurent

> Andreas.
> ---
> From 07f10a1b4a4aa4a54468e1106a4bbc28c5ada45e Mon Sep 17 00:00:00 2001
> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sat, 30 May 2009 23:52:11 +0200
> Subject: [PATCH] m68k: fix decoding of dbcc
>=20
> The counter needs to be compared with -1, not 0.
>=20
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
>  target-m68k/translate.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 9d68b02..ea6b34b 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -942,7 +942,7 @@ DISAS_INSN(dbcc)
>      tcg_gen_ext16s_i32(tmp, reg);
>      tcg_gen_addi_i32(tmp, tmp, -1);
>      gen_partset_reg(OS_WORD, reg, tmp);
> -    tcg_gen_brcondi_i32(TCG_COND_EQ, tmp, 0, l1);
> +    tcg_gen_brcondi_i32(TCG_COND_EQ, tmp, -1, l1);
>      gen_jmp_tb(s, 1, base + offset);
>      gen_set_label(l1);
>      gen_jmp_tb(s, 0, s->pc);
> --=20
> 1.6.3.1
>=20