From: Laurent Vivier <Laurent@vivier.eu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 1/3] m68k: allow fpu to manage double single data type.
Date: Sun, 31 May 2009 14:57:12 +0200 [thread overview]
Message-ID: <1243774632.5668.4.camel@Quad> (raw)
In-Reply-To: <m2tz31h434.fsf@igel.home>
Le dimanche 31 mai 2009 à 14:03 +0200, Andreas Schwab a écrit :
> Laurent Vivier <laurent@vivier.eu> writes:
>
> > + if ((insn & 7) == 4) {
> > + src = gen_load64(s, tcg_const_i32(s->pc));
> > + s->pc += 8;
>
> This is wrong, it doesn't check that this is indeed a 7.4 addressing
> mode, but will match any other mode with register 4.
>
> > + case 7:
> > + offset = ldsw_code(s->pc);
> > + offset += s->pc - 2;
> > + s->pc += 2;
> > + tcg_gen_addi_i32(tmp32, tmp32, offset);
> > + break;
>
> Btw, this is still broken, pc-rel addressing surely does not want the
> contents of register a2 added in (and the 68k supports all the indexed
> modes as well). All non-immediate addresses should probably be handled
> by gen_lea.
Yes, I agree, I rework this part.
Laurent
prev parent reply other threads:[~2009-05-31 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 0:50 [Qemu-devel] [PATCH 0/3] m68k: Some FPU enhancements Laurent Vivier
2009-05-31 0:50 ` [Qemu-devel] [PATCH 1/3] m68k: allow fpu to manage double single data type Laurent Vivier
2009-05-31 0:50 ` [Qemu-devel] [PATCH 2/3] m68k: add FScc instruction Laurent Vivier
2009-05-31 0:50 ` [Qemu-devel] [PATCH 3/3] m68k: add single data type to gen_ea Laurent Vivier
2009-05-31 12:03 ` [Qemu-devel] Re: [PATCH 1/3] m68k: allow fpu to manage double single data type Andreas Schwab
2009-05-31 12:57 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243774632.5668.4.camel@Quad \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).