[Qemu-devel] [PATCH] target-ppc: permit linux-user to read PVR

[Qemu-devel] [PATCH] target-ppc: permit linux-user to read PVR

[Nathan Froyd]

Access to the PVR SPR is normally forbidden from userspace apps.  The
Linux kernel, however, fixes up reads in the appropriate trap handler.
To permit applications that read PVR to run on QEMU, then, we need to
implement the same handling of PVR reads.

Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
---
 target-ppc/translate_init.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index f5e3b28..ef1987a 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -8903,7 +8903,13 @@ static void init_ppc_proc (CPUPPCState *env, const ppc_def_t *def)
     /* Register SPR common to all PowerPC implementations */
     gen_spr_generic(env);
     spr_register(env, SPR_PVR, "PVR",
-                 SPR_NOACCESS, SPR_NOACCESS,
+                 /* Linux permits userspace to read PVR */
+#if defined(CONFIG_LINUX_USER)
+                 &spr_read_generic,
+#else
+                 SPR_NOACCESS,
+#endif
+                 SPR_NOACCESS,
                  &spr_read_generic, SPR_NOACCESS,
                  def->pvr);
     /* Register SVR if it's defined to anything else than POWERPC_SVR_NONE */
-- 
1.6.3.2

Re: [Qemu-devel] [PATCH] target-ppc: permit linux-user to read PVR

[Nathan Froyd]

On Thu, Jun 04, 2009 at 06:45:03PM -0700, Nathan Froyd wrote:
> Access to the PVR SPR is normally forbidden from userspace apps.  The
> Linux kernel, however, fixes up reads in the appropriate trap handler.
> To permit applications that read PVR to run on QEMU, then, we need to
> implement the same handling of PVR reads.

Ping.

-Nathan