From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ME6wk-0002fv-84 for qemu-devel@nongnu.org; Tue, 09 Jun 2009 15:25:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ME6wf-0002eC-BO for qemu-devel@nongnu.org; Tue, 09 Jun 2009 15:25:21 -0400 Received: from [199.232.76.173] (port=53359 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ME6wf-0002e4-0y for qemu-devel@nongnu.org; Tue, 09 Jun 2009 15:25:17 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37343) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ME6we-0000dJ-HY for qemu-devel@nongnu.org; Tue, 09 Jun 2009 15:25:16 -0400 Subject: Re: [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements From: Mark McLoughlin In-Reply-To: <20090605204647.3355.81929.stgit@kvm.aw> References: <20090605204647.3355.81929.stgit@kvm.aw> Content-Type: text/plain Date: Tue, 09 Jun 2009 19:25:10 +0000 Message-Id: <1244575510.11883.172.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: Mark McLoughlin List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: Rusty Russell , qemu-devel@nongnu.org Hi Alex, On Fri, 2009-06-05 at 14:46 -0600, Alex Williamson wrote: > This series cleans up a few things around packet filtering. I've probably > gone a little overboard on breaking up patches, if we want to avoid bumping > the save version_id so much, these could be mostly lumped together. The > main features here are more efficient handling of the filtering between > unicast and multicast, better overflow tracking, adding more RX modes, > and increasing the size of the filter table and control queue depth. > > I took the reserved version_id 7 for vnet header support into consideration > on the first patch. I think we should be able to safely add the guts later > with the placeholder. If there are other RX mode controls we should add, > let me know, now would be a good time to round out any other flags we can > think of. The whole series looks good to me. Please make sure to send Rusty a patch with the VIRTIO_NET_F_CTRL_RX_EXTRA etc. header additions. The savevm version_id 9 bump is a little gratuitous, but I don't think it's a big deal - I'd prefer to see cleanly separated patches like this, and it wouldn't have been easy to e.g. split out the savevm changes into a patch of their own at the end. The vnet header version_id reservation is a good idea. I've given this stuff some light testing, but would you care to outline some instructions for some basic tests for as much as possible of this stuff using a Linux guest? i.e. broadcast, multicast, promisc, mac table, vlan table etc. - that's quite a set of tests you need to cover all those cases. Cheers, Mark.