From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEUe9-0003xr-Lb
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 16:43:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEUe5-0003un-L7
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 16:43:45 -0400
Received: from [199.232.76.173] (port=33235 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEUe5-0003uf-IF
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 16:43:41 -0400
Received: from g4t0015.houston.hp.com ([15.201.24.18]:6911)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <alex.williamson@hp.com>) id 1MEUe4-0004K8-GI
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 16:43:41 -0400
Subject: Re: [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements
From: Alex Williamson <alex.williamson@hp.com>
In-Reply-To: <200906101621.07565.rusty@rustcorp.com.au>
References: <20090605204647.3355.81929.stgit@kvm.aw>
	<1244575510.11883.172.camel@blaa>
	<200906101621.07565.rusty@rustcorp.com.au>
Content-Type: text/plain
Date: Wed, 10 Jun 2009 14:43:11 -0600
Message-Id: <1244666591.1715.8.camel@lappy>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org

On Wed, 2009-06-10 at 16:21 +0930, Rusty Russell wrote:
> On Wed, 10 Jun 2009 04:55:10 am Mark McLoughlin wrote:
> > Hi Alex,
> >
> > On Fri, 2009-06-05 at 14:46 -0600, Alex Williamson wrote:
> > > This series cleans up a few things around packet filtering.  I've
> > > probably gone a little overboard on breaking up patches, if we want to
> > > avoid bumping the save version_id so much, these could be mostly lumped
> > > together.  The main features here are more efficient handling of the
> > > filtering between unicast and multicast, better overflow tracking, adding
> > > more RX modes, and increasing the size of the filter table and control
> > > queue depth.
> >
> > The whole series looks good to me. Please make sure to send Rusty a
> > patch with the VIRTIO_NET_F_CTRL_RX_EXTRA etc. header additions.
> 
> Remain unconvinced that it's worth a feature bit.  It'd pretty obscure (hell, 
> even multicast is pretty obscure IRL).

I wasn't sure about the feature bit, so I decided to error on the side
of caution and add it.  It seems to fit the existing model of knowing
what's available via features instead of probing.  If you're opposed to
it, that part can be dropped.  Thanks,

Alex