From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEVzw-00039h-Eq
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 18:10:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEVzq-00037c-K7
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 18:10:19 -0400
Received: from [199.232.76.173] (port=40391 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEVzq-00037P-9v
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 18:10:14 -0400
Received: from mx2.redhat.com ([66.187.237.31]:44558)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <ehabkost@redhat.com>) id 1MEVzp-00009L-Ho
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 18:10:14 -0400
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on
	configure
From: Eduardo Habkost <ehabkost@raisama.net>
References: <1244582792-30589-1-git-send-email-ehabkost@redhat.com>
	<1244582792-30589-3-git-send-email-ehabkost@redhat.com>
	<87ocsxoye4.fsf@lechat.rtp-net.org>
	<20090610141255.GZ18045@blackpad>
	<87bpownof6.fsf@lechat.rtp-net.org>
	<1244659259-sup-8660@blackpad> <20090610214826.GC23525@kos.to>
In-Reply-To: <20090610214826.GC23525@kos.to>
Date: Wed, 10 Jun 2009 19:09:56 -0300
Message-Id: <1244670940-sup-4117@blackpad>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, "Arnaud Patard (Rtp)" <arnaud.patard@rtp-net.org>

Excerpts from Riku Voipio's message of Wed Jun 10 18:48:26 -0300 2009:
> On Wed, Jun 10, 2009 at 04:10:33PM -0300, Eduardo Habkost wrote:
> > > glibc utimensat is not exactly the syscall, a test on some parameters
> > > has been added. There's code to handle this in the patch I was talking
> > > about.
> 
> > Understood. However, my patch addresses a different issue, that is the
> > case where the host system doesn't have utimensat() available. The point
> > here is to disable the code that uses utimensat() (be it broken or not)
> > on that case.
> 
> > And the first patch is unrelated to that question: it is just a
> > correctness issue to make sure the xxxat() availability matches the
> > situation detected by ./configure (whose test code has #define
> > _ATFILE_SOURCE).
> 
> You mean like this, in the same thread? :)
> 
> http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01324.html

Yes.  :)

I saw the futimens() part, but I didn't see it was adding a new
configure test including utimensat(), on the first look.


> 
> However your other patch was useful, _ATFILE_SOURCE should be used in syscall.c
> to.
> thanks, applied to the maemo tree.

Cool. :)

Now, we really need to get the fixes from the maemo tree merged on the
master repository. How much have the trees diverged?
-- 
Eduardo