From: Mark McLoughlin <markmc@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default
Date: Thu, 11 Jun 2009 19:38:45 +0100 [thread overview]
Message-ID: <1244745525.4590.1.camel@blaa> (raw)
In-Reply-To: <4A314D2D.2060505@codemonkey.ws>
On Thu, 2009-06-11 at 13:30 -0500, Anthony Liguori wrote:
> How about the following? It currently only enables werror for Linux
> hosts and git builds.
>
...
> +# Consult white-list to determine whether to enable werror
> +# by default. Only enable by default for git builds
> +if test -z "$werror" ; then
> + z_version=`cut -f3 -d. $source_path/VERSION`
> + if test "$z_version" = "50" -a \
Looks good, except this will enable it in kvm-XX releases, and not in
future stable branches.
How about just 'test -d $source_path/.git/' ?
Cheers,
Mark.
next prev parent reply other threads:[~2009-06-11 18:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 12:35 [Qemu-devel] [RFC] Enable Werrror by default Paul Brook
2009-06-11 12:46 ` Tristan Gingold
2009-06-11 13:10 ` Christoph Egger
2009-06-11 14:02 ` Andreas Färber
2009-06-11 12:58 ` Anthony Liguori
2009-06-11 13:14 ` Mark McLoughlin
2009-06-11 13:34 ` Christoph Egger
2009-06-11 13:35 ` Paul Brook
2009-06-11 14:20 ` Richard W.M. Jones
2009-06-11 18:30 ` Anthony Liguori
2009-06-11 18:38 ` Mark McLoughlin [this message]
2009-06-11 20:03 ` Anthony Liguori
2009-06-11 22:28 ` Paul Brook
2009-06-11 15:18 ` David Turner
2009-06-11 17:24 ` Stuart Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244745525.4590.1.camel@blaa \
--to=markmc@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).