From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEpCv-0007mM-L3
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 14:41:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEpCr-0007kx-3e
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 14:41:01 -0400
Received: from [199.232.76.173] (port=56344 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEpCq-0007ks-UH
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 14:40:57 -0400
Received: from mx2.redhat.com ([66.187.237.31]:38925)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MEpCq-0005zN-Hi
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 14:40:56 -0400
Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <4A314D2D.2060505@codemonkey.ws>
References: <200906111335.10116.paul@codesourcery.com>
	<1244726086.7752.25.camel@blaa>  <4A314D2D.2060505@codemonkey.ws>
Content-Type: text/plain
Date: Thu, 11 Jun 2009 19:38:45 +0100
Message-Id: <1244745525.4590.1.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

On Thu, 2009-06-11 at 13:30 -0500, Anthony Liguori wrote:

> How about the following?  It currently only enables werror for Linux 
> hosts and git builds.
> 
... 
> +# Consult white-list to determine whether to enable werror
> +# by default.  Only enable by default for git builds
> +if test -z "$werror" ; then
> +    z_version=`cut -f3 -d. $source_path/VERSION`
> +    if test "$z_version" = "50" -a \

Looks good, except this will enable it in kvm-XX releases, and not in
future stable branches.

How about just 'test -d $source_path/.git/' ?

Cheers,
Mark.