From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MF85Q-0007y3-D3 for qemu-devel@nongnu.org; Fri, 12 Jun 2009 10:50:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MF85L-0007ru-He for qemu-devel@nongnu.org; Fri, 12 Jun 2009 10:50:31 -0400 Received: from [199.232.76.173] (port=35582 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MF85L-0007rO-2b for qemu-devel@nongnu.org; Fri, 12 Jun 2009 10:50:27 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39606) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MF85K-0004J3-Qs for qemu-devel@nongnu.org; Fri, 12 Jun 2009 10:50:27 -0400 Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities] From: Mark McLoughlin In-Reply-To: <20090612135936.GA25912@redhat.com> References: <20090610145540.GI19375@poweredge.glommer> <20090610150129.GC28601@redhat.com> <200906101624.30659.paul@codesourcery.com> <20090610174301.GC7416@shareable.org> <20090610182227.GN28601@redhat.com> <20090610192702.GH7416@shareable.org> <1244796209.16425.20.camel@blaa> <20090612135936.GA25912@redhat.com> Content-Type: text/plain Date: Fri, 12 Jun 2009 15:48:14 +0100 Message-Id: <1244818094.30522.45.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: Mark McLoughlin List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Carsten Otte , kvm@vger.kernel.org, Glauber Costa , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl , Christian Borntraeger , Paul Brook , Avi Kivity On Fri, 2009-06-12 at 16:59 +0300, Michael S. Tsirkin wrote: > On Fri, Jun 12, 2009 at 09:43:29AM +0100, Mark McLoughlin wrote: > > = Solution - Separate configuration from compat hints = > > > > As I suggested before: > > > > - Allow the VM manager to dump compat hints; this would be an opaque > > file format, more like the savevm format than a config file > > Why make it "like the savevm" format then? > If they are opaque anyway, compat hints could be part of savevm format. So a "savevm --only-compat-hints" command? It might make sense, since we would want the compat hints with savevm too. > > - Use defaults where compat hints are not available; e.g. if the VM > > manager specifies a device config, but no compat hints are > > supplied for it, then just use default values > > > > - Make the config override compat hints; e.g. if there are compat > > hints specified for a device not included in the machine config, > > just ignore those hints > > > > Cheers, > > Mark. > > If compat hints are opaque and only editable by qemu, we can get into a > situation where one can't create a specific setup with a new qemu. An example? Cheers, Mark.