From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MFAEX-0007dq-HX
	for qemu-devel@nongnu.org; Fri, 12 Jun 2009 13:08:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MFAES-0007L1-11
	for qemu-devel@nongnu.org; Fri, 12 Jun 2009 13:08:04 -0400
Received: from [199.232.76.173] (port=54805 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MFAER-0007Kr-Rs
	for qemu-devel@nongnu.org; Fri, 12 Jun 2009 13:07:59 -0400
Received: from mx2.redhat.com ([66.187.237.31]:58391)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MFAER-00074c-4a
	for qemu-devel@nongnu.org; Fri, 12 Jun 2009 13:07:59 -0400
Subject: Re: [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <200906101621.07565.rusty@rustcorp.com.au>
References: <20090605204647.3355.81929.stgit@kvm.aw>
	<1244575510.11883.172.camel@blaa>
	<200906101621.07565.rusty@rustcorp.com.au>
Content-Type: text/plain
Date: Fri, 12 Jun 2009 18:07:54 +0100
Message-Id: <1244826474.26769.23.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: qemu-devel@nongnu.org, Alex Williamson <alex.williamson@hp.com>

On Wed, 2009-06-10 at 16:21 +0930, Rusty Russell wrote:
> On Wed, 10 Jun 2009 04:55:10 am Mark McLoughlin wrote:
> > Hi Alex,
> >
> > On Fri, 2009-06-05 at 14:46 -0600, Alex Williamson wrote:
> > > This series cleans up a few things around packet filtering.  I've
> > > probably gone a little overboard on breaking up patches, if we want to
> > > avoid bumping the save version_id so much, these could be mostly lumped
> > > together.  The main features here are more efficient handling of the
> > > filtering between unicast and multicast, better overflow tracking, adding
> > > more RX modes, and increasing the size of the filter table and control
> > > queue depth.
> >
> > The whole series looks good to me. Please make sure to send Rusty a
> > patch with the VIRTIO_NET_F_CTRL_RX_EXTRA etc. header additions.
> 
> Remain unconvinced that it's worth a feature bit.  It'd pretty obscure (hell, 
> even multicast is pretty obscure IRL).

Yeah, we probably don't need the feature bit - the guest can just handle
a VIRTIO_NET_ERR status if the host doesn't implement it.

Alex - if you agree, could you post a qemu patch to kill the
CTRL_RX_EXTRA feature? And also post a linux/virtio_net.h patch to add
the new rx modes?

Thanks,
Mark.