From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MFCI2-0003V7-HE for qemu-devel@nongnu.org; Fri, 12 Jun 2009 15:19:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MFCHw-0003SX-Sz for qemu-devel@nongnu.org; Fri, 12 Jun 2009 15:19:49 -0400 Received: from [199.232.76.173] (port=58829 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MFCHw-0003SL-Id for qemu-devel@nongnu.org; Fri, 12 Jun 2009 15:19:44 -0400 Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:32417) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MFCHv-000537-HR for qemu-devel@nongnu.org; Fri, 12 Jun 2009 15:19:44 -0400 Subject: Re: [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements From: Alex Williamson In-Reply-To: <1244826474.26769.23.camel@blaa> References: <20090605204647.3355.81929.stgit@kvm.aw> <1244575510.11883.172.camel@blaa> <200906101621.07565.rusty@rustcorp.com.au> <1244826474.26769.23.camel@blaa> Content-Type: text/plain Date: Fri, 12 Jun 2009 13:19:19 -0600 Message-Id: <1244834359.1715.14.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Rusty Russell , qemu-devel@nongnu.org On Fri, 2009-06-12 at 18:07 +0100, Mark McLoughlin wrote: > On Wed, 2009-06-10 at 16:21 +0930, Rusty Russell wrote: > > On Wed, 10 Jun 2009 04:55:10 am Mark McLoughlin wrote: > > > Hi Alex, > > > > > > On Fri, 2009-06-05 at 14:46 -0600, Alex Williamson wrote: > > > > This series cleans up a few things around packet filtering. I've > > > > probably gone a little overboard on breaking up patches, if we want to > > > > avoid bumping the save version_id so much, these could be mostly lumped > > > > together. The main features here are more efficient handling of the > > > > filtering between unicast and multicast, better overflow tracking, adding > > > > more RX modes, and increasing the size of the filter table and control > > > > queue depth. > > > > > > The whole series looks good to me. Please make sure to send Rusty a > > > patch with the VIRTIO_NET_F_CTRL_RX_EXTRA etc. header additions. > > > > Remain unconvinced that it's worth a feature bit. It'd pretty obscure (hell, > > even multicast is pretty obscure IRL). > > Yeah, we probably don't need the feature bit - the guest can just handle > a VIRTIO_NET_ERR status if the host doesn't implement it. > > Alex - if you agree, could you post a qemu patch to kill the > CTRL_RX_EXTRA feature? And also post a linux/virtio_net.h patch to add > the new rx modes? Two votes against it, I'll drop the feature bit. I'll post the qemu patch in a minute and follow-up with the linux patch once that goes in. Thanks, Alex