From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>,
Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH] Win32: Don't remove const attribute in type casts.
Date: Sat, 13 Jun 2009 13:05:27 +0200 [thread overview]
Message-ID: <1244891127-15561-1-git-send-email-weil@mail.berlios.de> (raw)
Type casts removing the const attribute are bad because
they hide the fact that the argument remains const.
They also result in a compiler warning (at least with MS-C).
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
net.c | 2 +-
qemu-char.c | 2 +-
vnc.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net.c b/net.c
index 58d68b5..af9de73 100644
--- a/net.c
+++ b/net.c
@@ -1507,7 +1507,7 @@ static ssize_t net_socket_receive_dgram(VLANClientState *vc, const uint8_t *buf,
{
NetSocketState *s = vc->opaque;
- return sendto(s->fd, (void *)buf, size, 0,
+ return sendto(s->fd, (const void *)buf, size, 0,
(struct sockaddr *)&s->dgram_dst, sizeof(s->dgram_dst));
}
diff --git a/qemu-char.c b/qemu-char.c
index a63d860..a8afe94 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1708,7 +1708,7 @@ static int udp_chr_write(CharDriverState *chr, const uint8_t *buf, int len)
{
NetCharDriver *s = chr->opaque;
- return sendto(s->fd, (void *)buf, len, 0,
+ return sendto(s->fd, (const void *)buf, len, 0,
(struct sockaddr *)&s->daddr, sizeof(struct sockaddr_in));
}
diff --git a/vnc.c b/vnc.c
index 109c2f3..e1ca9f8 100644
--- a/vnc.c
+++ b/vnc.c
@@ -961,7 +961,7 @@ long vnc_client_write_buf(VncState *vs, const uint8_t *data, size_t datalen)
}
} else
#endif /* CONFIG_VNC_TLS */
- ret = send(vs->csock, (void *)data, datalen, 0);
+ ret = send(vs->csock, (const void *)data, datalen, 0);
VNC_DEBUG("Wrote wire %p %zd -> %ld\n", data, datalen, ret);
return vnc_client_io_error(vs, ret, socket_error());
}
--
1.5.6.5
next reply other threads:[~2009-06-13 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 11:05 Stefan Weil [this message]
2009-06-13 11:33 ` [Qemu-devel] Re: [PATCH] Win32: Don't remove const attribute in type casts Blue Swirl
2009-06-13 16:30 ` [Qemu-devel] " Jamie Lokier
2009-06-13 18:58 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244891127-15561-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).