From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGZfg-00008Z-DZ for qemu-devel@nongnu.org; Tue, 16 Jun 2009 10:29:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGZfb-00006k-Cg for qemu-devel@nongnu.org; Tue, 16 Jun 2009 10:29:55 -0400 Received: from [199.232.76.173] (port=32808 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGZfb-00006e-9C for qemu-devel@nongnu.org; Tue, 16 Jun 2009 10:29:51 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:8556) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MGZfa-0008SS-VO for qemu-devel@nongnu.org; Tue, 16 Jun 2009 10:29:51 -0400 Subject: Re: [Qemu-devel] [PATCH] virtio-net: Remove RX_EXTRA feature From: Alex Williamson In-Reply-To: <200906161249.25971.rusty@rustcorp.com.au> References: <20090612191626.4227.7273.stgit@kvm.aw> <200906151448.14205.rusty@rustcorp.com.au> <1245077144.4851.25.camel@lappy> <200906161249.25971.rusty@rustcorp.com.au> Content-Type: text/plain Date: Tue, 16 Jun 2009 08:29:46 -0600 Message-Id: <1245162586.20622.9.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rusty Russell Cc: markmc@redhat.com, qemu-devel@nongnu.org, "Michael S. Tsirkin" On Tue, 2009-06-16 at 12:49 +0930, Rusty Russell wrote: > On Tue, 16 Jun 2009 12:15:44 am Alex Williamson wrote: > > On Mon, 2009-06-15 at 14:48 +0930, Rusty Russell wrote: > > > It's hard to see > > > the use case where this feature offers significant advantages over > > > promisc. Without that, I'd wait until someone reports a need. > > > > Thanks for clarifying, a need has been reported. DMX is a proprietary > > OS that intends to run on KVM and make use of virtio-net. They would > > like to be able to toggle unicast and multicast independently as well as > > mask broadcast traffic. The original series re-arranged some of the > > filter code in the virtio-net backend that allows these filter options > > to drop out nicely. > > That's sufficient for me. Great, this feature bit removal patch is official dead then. > Could you re-send feature-based patches if you're happy? The feature based version already went into the tree via Mark's patch queue, but I'll bounce you copies in case you have any comments that we can fixup in tree before we sync the Linux virtio-net header. Thanks, Alex