From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGqct-00055v-TO
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 04:36:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGqco-0004zO-PW
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 04:36:11 -0400
Received: from [199.232.76.173] (port=43913 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGqco-0004z9-Jy
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 04:36:06 -0400
Received: from mx2.redhat.com ([66.187.237.31]:49555)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MGqcn-0007ft-N7
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 04:36:06 -0400
Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3
	03/13] qemu: add routines to manage PCI capabilities]
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <20090616184404.GJ11893@shareable.org>
References: <4A364FE0.40204@redhat.com> <4A3651EB.3070204@codemonkey.ws>
	<4A36555A.4090303@redhat.com> <4A3659A0.3050108@codemonkey.ws>
	<4A366348.1030202@redhat.com> <1245083229.3222.103.camel@blaa>
	<4A368F12.2090504@codemonkey.ws> <1245154451.11407.22.camel@blaa>
	<4A378FE5.5050303@redhat.com> <1245155992.30082.8.camel@blaa>
	<20090616184404.GJ11893@shareable.org>
Content-Type: text/plain
Date: Wed, 17 Jun 2009 09:33:52 +0100
Message-Id: <1245227632.27028.29.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: Carsten Otte <cotte@de.ibm.com>, Rusty Russell <rusty@rustcorp.com.au>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Glauber Costa <glommer@redhat.com>, dlaor@redhat.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Avi Kivity <avi@redhat.com>, Paul Brook <paul@codesourcery.com>

On Tue, 2009-06-16 at 19:44 +0100, Jamie Lokier wrote:
> Mark McLoughlin wrote:
> > > Worst case we hardcode those numbers (gasp, faint).
> > 
> > Maybe we can just add the open slots to the -help output. That'd be nice
> > and clean.

I was being sarcastic - libvirt currently must parse qemu -help, and
even has some test infrastructure to check that it works with various
versions of qemu. Extending this would not be nice and clean :-)

> I particularly don't like the idea of arcane machine-dependent slot
> allocation knowledge living in libvirt, because it needs to be in Qemu
> anyway for non-libvirt users.  No point in having two implementations
> of something tricky and likely to have machine quirks, if one will do.

Indeed.

Cheers,
Mark.