* [Qemu-devel] [PATCH] Fix hxtool.
@ 2009-06-20 12:12 Stefan Weil
2009-07-01 17:13 ` [Qemu-devel][PATCH] " Stefan Weil
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2009-06-20 12:12 UTC (permalink / raw)
To: QEMU Developers
When converting from hx to texi format, hxtool (or to be
more precise sh which interprets hxtool) used standard
shell expansion of wildcards while writing lines to the
output.
Thus, something like "Password: ********"
looked very different in the generated documentation.
The patch disables this unwanted wildcard expansion.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
hxtool | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hxtool b/hxtool
index 885abe2..0fdbc64 100644
--- a/hxtool
+++ b/hxtool
@@ -26,10 +26,10 @@ hxtotexi()
STEXI*|ETEXI*) flag=$(($flag^1))
;;
DEFHEADING*)
- echo $(expr "$str" : "DEFHEADING(\(.*\))")
+ echo "$(expr "$str" : "DEFHEADING(\(.*\))")"
;;
*)
- test $flag -eq 1 && echo $str
+ test $flag -eq 1 && echo "$str"
;;
esac
done
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel][PATCH] Fix hxtool.
2009-06-20 12:12 [Qemu-devel] [PATCH] Fix hxtool Stefan Weil
@ 2009-07-01 17:13 ` Stefan Weil
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2009-07-01 17:13 UTC (permalink / raw)
To: Anthony Liguori; +Cc: QEMU Developers
Stefan Weil schrieb:
> When converting from hx to texi format, hxtool (or to be
> more precise sh which interprets hxtool) used standard
> shell expansion of wildcards while writing lines to the
> output.
>
> Thus, something like "Password: ********"
> looked very different in the generated documentation.
>
> The patch disables this unwanted wildcard expansion.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hxtool | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hxtool b/hxtool
> index 885abe2..0fdbc64 100644
> --- a/hxtool
> +++ b/hxtool
> @@ -26,10 +26,10 @@ hxtotexi()
> STEXI*|ETEXI*) flag=$(($flag^1))
> ;;
> DEFHEADING*)
> - echo $(expr "$str" : "DEFHEADING(\(.*\))")
> + echo "$(expr "$str" : "DEFHEADING(\(.*\))")"
> ;;
> *)
> - test $flag -eq 1 && echo $str
> + test $flag -eq 1 && echo "$str"
> ;;
> esac
> done
>
The patch is still missing in qemu.git. Without it, the next
version of http://www.nongnu.org/qemu/qemu-doc.html
will look bad. ;-)
Regards,
Stefan Weil
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <4A4BA43D.6040303@us.ibm.com>]
* [Qemu-devel] [PATCH] Fix hxtool.
[not found] <4A4BA43D.6040303@us.ibm.com>
@ 2009-07-01 21:13 ` Stefan Weil
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2009-07-01 21:13 UTC (permalink / raw)
To: aliguori; +Cc: QEMU Developers
When converting from hx to texi format, hxtool (or to be
more precise sh which interprets hxtool) used standard
shell expansion of wildcards while writing lines to the
output.
Thus, something like "Password: ********"
looked very different in the generated documentation.
The patch disables this unwanted wildcard expansion.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
hxtool | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hxtool b/hxtool
index 885abe2..0fdbc64 100644
--- a/hxtool
+++ b/hxtool
@@ -26,10 +26,10 @@ hxtotexi()
STEXI*|ETEXI*) flag=$(($flag^1))
;;
DEFHEADING*)
- echo $(expr "$str" : "DEFHEADING(\(.*\))")
+ echo "$(expr "$str" : "DEFHEADING(\(.*\))")"
;;
*)
- test $flag -eq 1 && echo $str
+ test $flag -eq 1 && echo "$str"
;;
esac
done
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-01 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-20 12:12 [Qemu-devel] [PATCH] Fix hxtool Stefan Weil
2009-07-01 17:13 ` [Qemu-devel][PATCH] " Stefan Weil
[not found] <4A4BA43D.6040303@us.ibm.com>
2009-07-01 21:13 ` [Qemu-devel] [PATCH] " Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).