From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJivv-00063S-JQ
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 02:59:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJivr-0005vI-H8
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 02:59:43 -0400
Received: from [199.232.76.173] (port=37601 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJivr-0005v9-AG
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 02:59:39 -0400
Received: from mx20.gnu.org ([199.232.41.8]:53332)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <markmc@redhat.com>) id 1MJivq-00035q-Py
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 02:59:38 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MJivp-000534-HM
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 02:59:37 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5P6xaks017281
	for <qemu-devel@nongnu.org>; Thu, 25 Jun 2009 02:59:36 -0400
Subject: Re: [Qemu-devel] [PATCH 06/14] Rename SLIRP_OBJS to slirp-obj-y
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <de2298e99d0b35bc6c5842c4cdad6f72d8a5f6fb.1245880275.git.quintela@redhat.com>
References: <cover.1245880275.git.quintela@redhat.com>
	<de2298e99d0b35bc6c5842c4cdad6f72d8a5f6fb.1245880275.git.quintela@redhat.com>
Content-Type: text/plain
Date: Thu, 25 Jun 2009 07:59:25 +0100
Message-Id: <1245913165.29909.15.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org

On Thu, 2009-06-25 at 00:08 +0200, quintela@redhat.com wrote:

> diff --git a/Makefile b/Makefile
> index 802d276..d316388 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -188,10 +188,10 @@ endif
> 
>  ifdef CONFIG_SLIRP
>  CPPFLAGS+=-I$(SRC_PATH)/slirp
> -SLIRP_OBJS=cksum.o if.o ip_icmp.o ip_input.o ip_output.o \
> -slirp.o mbuf.o misc.o sbuf.o socket.o tcp_input.o tcp_output.o \
> -tcp_subr.o tcp_timer.o udp.o bootp.o debug.o tftp.o
> -OBJS+=$(addprefix slirp/, $(SLIRP_OBJS))
> +slirp-obj-y = cksum.o if.o ip_icmp.o ip_input.o ip_output.o
> +slirp-obj-y += slirp.o mbuf.o misc.o sbuf.o socket.o tcp_input.o tcp_output.o
> +slirp-obj-y += tcp_subr.o tcp_timer.o udp.o bootp.o debug.o tftp.o
> +OBJS+=$(addprefix slirp/, $(slirp-obj-y))

I like the whole series, but I think I'd drop this change and the
XEN_OBJS change.

We won't be individually configuring out any of SLIRP_OBJS, so an end
result like:

  obj-$(CONFIG_SLIRP) += $(addprefix slirp/, $(SLIRP_OBJS))

seems nicer to me than:

  obj-$(CONFIG_SLIRP) += $(addprefix slirp/, $(slirp-obj-y))

Cheers,
Mark.