From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 06/20] qdev/pci: misc fixes.
Date: Mon, 29 Jun 2009 14:46:07 +0200 [thread overview]
Message-ID: <1246279581-15749-7-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1246279581-15749-1-git-send-email-kraxel@redhat.com>
* use core busnr.
* fix secondary bus setup.
* use base->name instead of "FIXME" for device name.
Yes, the device name is redundant. Only for drivers converted
to qdev already though. Once all drivers are converted we can
and should kill it.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/pci.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index c537ed0..5925617 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -115,7 +115,6 @@ PCIBus *pci_register_bus(DeviceState *parent, const char *name,
qemu_irq *pic, int devfn_min, int nirq)
{
PCIBus *bus;
- static int nbus = 0;
bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, parent, name));
bus->set_irq = set_irq;
@@ -126,7 +125,7 @@ PCIBus *pci_register_bus(DeviceState *parent, const char *name,
bus->irq_count = qemu_malloc(nirq * sizeof(bus->irq_count[0]));
bus->next = first_bus;
first_bus = bus;
- register_savevm("PCIBUS", nbus++, 1, pcibus_save, pcibus_load, bus);
+ register_savevm("PCIBUS", bus->qbus.busnr, 1, pcibus_save, pcibus_load, bus);
qemu_register_reset(pci_bus_reset, 0, bus);
return bus;
}
@@ -134,7 +133,8 @@ PCIBus *pci_register_bus(DeviceState *parent, const char *name,
static PCIBus *pci_register_secondary_bus(PCIDevice *dev, pci_map_irq_fn map_irq)
{
PCIBus *bus;
- bus = qemu_mallocz(sizeof(PCIBus));
+
+ bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev, NULL));
bus->map_irq = map_irq;
bus->parent_dev = dev;
bus->next = dev->bus->next;
@@ -954,7 +954,7 @@ static void pci_qdev_init(DeviceState *qdev, DeviceInfo *base)
bus = FROM_QBUS(PCIBus, qdev_get_parent_bus(qdev));
devfn = qdev_get_prop_int(qdev, "devfn", -1);
- pci_dev = do_pci_register_device(pci_dev, bus, "FIXME", devfn,
+ pci_dev = do_pci_register_device(pci_dev, bus, base->name, devfn,
info->config_read, info->config_write);
assert(pci_dev);
info->init(pci_dev);
--
1.6.2.5
next prev parent reply other threads:[~2009-06-29 12:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 12:46 [Qemu-devel] [PATCH 0/20] qdev patches Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 01/20] qdev: update pci device registration Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 02/20] qdev: replace bus_type enum with bus_info struct Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 03/20] qdev: remove DeviceType Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 04/20] qdev/core: bus list Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 05/20] qdev/core: add monitor command to list all drivers Gerd Hoffmann
2009-06-29 12:46 ` Gerd Hoffmann [this message]
2009-06-29 12:46 ` [Qemu-devel] [PATCH 07/20] qdev/pci: hook up i440fx Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 08/20] qdev: convert piix-ide Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 09/20] qdev: convert piix acpi Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 10/20] qdev: convert all vga Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 11/20] qdev: convert es1370 Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 12/20] qdev: convert ac97 Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 13/20] qdev: convert uhci Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 14/20] qdev/usb: add usb bus support to qdev, convert drivers Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 15/20] qdev/usb: make qemu aware of usb busses Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 16/20] qdev/usb: print usb dev info Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 17/20] qdev: convert ohci Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 18/20] qdev/scsi: add scsi bus support to qdev, convert drivers Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 19/20] debug/test patch: add ohci controller to pc Gerd Hoffmann
2009-06-29 12:46 ` [Qemu-devel] [PATCH 20/20] debug/test patch: allow specify busnr for -usbdevice Gerd Hoffmann
2009-06-30 0:56 ` [Qemu-devel] [PATCH 0/20] qdev patches Anthony Liguori
2009-06-30 9:26 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246279581-15749-7-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).