qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 6/8] qdev/pci: misc fixes.
Date: Tue, 30 Jun 2009 11:26:00 +0200	[thread overview]
Message-ID: <1246353962-32308-7-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1246353962-32308-1-git-send-email-kraxel@redhat.com>

 * use core busnr.
 * fix secondary bus setup.
 * use base->name instead of "FIXME" for device name.
   Yes, the device name is redundant.  Only for drivers converted
   to qdev already though.  Once all drivers are converted we can
   and should kill it.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/pci.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/pci.c b/hw/pci.c
index fa618ee..8edbad8 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -115,7 +115,6 @@ PCIBus *pci_register_bus(DeviceState *parent, const char *name,
                          qemu_irq *pic, int devfn_min, int nirq)
 {
     PCIBus *bus;
-    static int nbus = 0;
 
     bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, parent, name));
     bus->set_irq = set_irq;
@@ -126,7 +125,7 @@ PCIBus *pci_register_bus(DeviceState *parent, const char *name,
     bus->irq_count = qemu_malloc(nirq * sizeof(bus->irq_count[0]));
     bus->next = first_bus;
     first_bus = bus;
-    register_savevm("PCIBUS", nbus++, 1, pcibus_save, pcibus_load, bus);
+    register_savevm("PCIBUS", bus->qbus.busnr, 1, pcibus_save, pcibus_load, bus);
     qemu_register_reset(pci_bus_reset, bus);
     return bus;
 }
@@ -134,7 +133,8 @@ PCIBus *pci_register_bus(DeviceState *parent, const char *name,
 static PCIBus *pci_register_secondary_bus(PCIDevice *dev, pci_map_irq_fn map_irq)
 {
     PCIBus *bus;
-    bus = qemu_mallocz(sizeof(PCIBus));
+
+    bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev, NULL));
     bus->map_irq = map_irq;
     bus->parent_dev = dev;
     bus->next = dev->bus->next;
@@ -890,7 +890,7 @@ static void pci_qdev_init(DeviceState *qdev, DeviceInfo *base)
 
     bus = FROM_QBUS(PCIBus, qdev_get_parent_bus(qdev));
     devfn = qdev_get_prop_int(qdev, "devfn", -1);
-    pci_dev = do_pci_register_device(pci_dev, bus, "FIXME", devfn,
+    pci_dev = do_pci_register_device(pci_dev, bus, base->name, devfn,
                                      info->config_read, info->config_write);
     assert(pci_dev);
     info->init(pci_dev);
-- 
1.6.2.5

  parent reply	other threads:[~2009-06-30  9:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30  9:25 [Qemu-devel] [PATCH 0/7] qdev patches, batch #1 Gerd Hoffmann
2009-06-30  9:25 ` [Qemu-devel] [PATCH 1/8] qdev: update pci device registration Gerd Hoffmann
2009-06-30  9:25 ` [Qemu-devel] [PATCH 2/8] qdev: replace bus_type enum with bus_info struct Gerd Hoffmann
2009-06-30  9:25 ` [Qemu-devel] [PATCH 3/8] qdev: remove DeviceType Gerd Hoffmann
2009-06-30  9:25 ` [Qemu-devel] [PATCH 4/8] qdev/core: bus list Gerd Hoffmann
2009-06-30 11:18   ` Paul Brook
2009-06-30 16:55     ` Markus Armbruster
2009-06-30 17:21       ` Paul Brook
2009-06-30 19:26         ` Markus Armbruster
2009-06-30 19:49           ` Anthony Liguori
2009-06-30 20:18             ` Gerd Hoffmann
2009-06-30 20:36               ` Anthony Liguori
2009-07-01  0:25               ` Paul Brook
2009-07-01  6:32                 ` Gerd Hoffmann
2009-07-01  0:12             ` Markus Armbruster
2009-07-01  0:29               ` Paul Brook
2009-06-30  9:25 ` [Qemu-devel] [PATCH 5/8] qdev/core: add monitor command to list all drivers Gerd Hoffmann
2009-06-30  9:26 ` Gerd Hoffmann [this message]
2009-06-30 11:25   ` [Qemu-devel] [PATCH 6/8] qdev/pci: misc fixes Paul Brook
2009-06-30 16:51     ` Markus Armbruster
2009-06-30  9:26 ` [Qemu-devel] [PATCH 7/8] qdev: convert es1370 Gerd Hoffmann
2009-06-30  9:26 ` [Qemu-devel] [PATCH 8/8] qdev: convert ac97 Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246353962-32308-7-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).