From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLdSZ-0002Mb-JU for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:33:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLdSV-0002KC-Mp for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:33:19 -0400 Received: from [199.232.76.173] (port=56047 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLdSV-0002Jq-Ex for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:33:15 -0400 Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:23370 helo=TX2EHSOBE008.bigfish.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16) (Exim 4.60) (envelope-from ) id 1MLdSU-0007nq-GZ for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:33:15 -0400 Subject: Re: [Qemu-devel] EXT3-fs error on Git HEAD From: Frank Arnold In-Reply-To: <4A49D5E2.4070705@redhat.com> References: <20090629095032.f729525f.mle+tools@mega-nerd.com> <20090629134201.4115de43.mle+tools@mega-nerd.com> <1246292869.13041.342.camel@mendozza.osrc.amd.com> <4A49D5E2.4070705@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 30 Jun 2009 15:32:36 +0200 Message-ID: <1246368756.15765.8.camel@mendozza.osrc.amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Christoph Hellwig Am Dienstag, den 30.06.2009, 11:07 +0200 schrieb Kevin Wolf: > Frank Arnold schrieb: > > commit ad53089b0d0b4bc0731d978e5713365e1a91ba74 > > Author: Christoph Hellwig > > Date: Mon May 25 15:45:37 2009 +0200 > >=20 > > qcow: add qcow_aio_setup helper >=20 > This one has an obvious bug. Does the following change help? >=20 > diff --git a/block/qcow.c b/block/qcow.c > index 55a68a6..7fc85ae 100644 > --- a/block/qcow.c > +++ b/block/qcow.c > @@ -723,7 +723,7 @@ static BlockDriverAIOCB > *qcow_aio_writev(BlockDriverState *bs, >=20 > s->cluster_cache_offset =3D -1; /* disable compressed cache */ >=20 > - acb =3D qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque,= 0); > + acb =3D qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque,= 1); > if (!acb) > return NULL; Yes, this change seems to fix it. The guest survived 3 hours of stress testing and the image was still intact. Tested on top of kvm-87-71-g6179556 (qemu-kvm.git). Thanks for looking into it. --=20 Frank Arnold System Design Technician, Software Test AMD Operating System Research Center Dresden, Germany Tel: +49 351 448 356702 Legal Information: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34 85609 Dornach b. M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Thomas M. McCoy; Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis M=C3=BCnchen Registergericht M=C3=BCnchen, HRB Nr. 43632