[Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev

[Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev

[Kevin Wolf]

Pass is_write = 1 to qcow_aio_setup when writing.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/qcow.c b/block/qcow.c
index 55a68a6..7fc85ae 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -723,7 +723,7 @@ static BlockDriverAIOCB *qcow_aio_writev(BlockDriverState *bs,
 
     s->cluster_cache_offset = -1; /* disable compressed cache */
 
-    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 0);
+    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 1);
     if (!acb)
         return NULL;
 
-- 
1.6.0.6

Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev

[Christoph Hellwig]

On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
> Pass is_write = 1 to qcow_aio_setup when writing.

Looks correct, sorry for introducing this.

Maybe we should add symbolic names for READ/WRITE in another patch to
make this more easily spottable?

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev

[Kevin Wolf]

Christoph Hellwig schrieb:
> On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
>> Pass is_write = 1 to qcow_aio_setup when writing.
> 
> Looks correct, sorry for introducing this.
> 
> Maybe we should add symbolic names for READ/WRITE in another patch to
> make this more easily spottable?

I'd expect we'll not see such things in the same place again, but
symbolic constants are always better. Are you going to prepare a patch?

Kevin

Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev

[Christoph Hellwig]

On Tue, Jun 30, 2009 at 06:55:13PM +0200, Kevin Wolf wrote:
> Christoph Hellwig schrieb:
> > On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
> >> Pass is_write = 1 to qcow_aio_setup when writing.
> > 
> > Looks correct, sorry for introducing this.
> > 
> > Maybe we should add symbolic names for READ/WRITE in another patch to
> > make this more easily spottable?
> 
> I'd expect we'll not see such things in the same place again, but
> symbolic constants are always better. Are you going to prepare a patch?

I'll put it on my todo list, after some higher priority items :)