From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNr3M-0005Oz-PB
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 12:28:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNr3I-0005LF-4e
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 12:28:28 -0400
Received: from [199.232.76.173] (port=42011 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNr3I-0005L3-0x
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 12:28:24 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:42287)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <linuxram@us.ibm.com>) id 1MNr3H-0008EE-DZ
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 12:28:23 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n66GKV0M016420
	for <qemu-devel@nongnu.org>; Mon, 6 Jul 2009 10:20:31 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n66GSECj255146
	for <qemu-devel@nongnu.org>; Mon, 6 Jul 2009 10:28:14 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n66GSEe0010563
	for <qemu-devel@nongnu.org>; Mon, 6 Jul 2009 10:28:14 -0600
From: Ram Pai <linuxram@us.ibm.com>
In-Reply-To: <4A511F7B.6040504@web.de>
References: <200906300055.n5U0tAD8013302@d03av01.boulder.ibm.com>
	<4A4F3967.9040106@web.de>  <4A511F7B.6040504@web.de>
Content-Type: text/plain
Date: Mon, 06 Jul 2009 09:28:08 -0700
Message-Id: <1246897688.6429.89.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [COMMIT 707c0db] support colon in filenames
Reply-To: linuxram@us.ibm.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On Sun, 2009-07-05 at 23:47 +0200, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Anthony,
> > 
> > please revert this patch until Ram Pai provides a better version. It
> > causes too many problems. At least it
Jan,

Yes I am working on the next revision of the patch. 

> > 
> >  - breaks -pflash somefile -snapshot
> 
> Some more details on this: it's not just pflash that suffers, -snapshot
> was broken for raw images in general. Declaring file access as a
> protocol apparently has some unwanted side effects that first have to be
> resolved (check also bdrv_open2 /wrt realpath).

I do not entirely understand the side effect. I will see if I can figure
this out. It will certainly help if you can elaborate more?

> 
> >  - breaks mingw32 build due to redefined _open
> 
> Sorry, this obviously does not apply to the merged revision 2 but to
> rev3 which I had applied locally.
> 
> >  - uses PATH_MAX

PATH_MAX is not defined in mingw32 environment? 

> > 
> > rev3 does not fix any of the above.
> > 
> > At this chance: there is at least one indention issue remaining in
> > fill_token() which would be nice to fix while reworking the patch.
> > 

yes. noted.

Thanks,
RP

> > Jan
> > 
> 
> Jan
>