From: Mark McLoughlin <markmc@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 1/3] Make tcp_chr_read() use recvmsg()
Date: Mon, 06 Jul 2009 18:30:56 +0100 [thread overview]
Message-ID: <1246901456.12086.21.camel@blaa> (raw)
In-Reply-To: <1246901401.12086.20.camel@blaa>
This makes no functional changes, just paves the way for the next
patch.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
qemu-char.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 287e0cd..e0d7220 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1911,15 +1911,25 @@ static void tcp_chr_read(void *opaque)
{
CharDriverState *chr = opaque;
TCPCharDriver *s = chr->opaque;
+ struct msghdr msg = { 0, };
+ struct iovec iov[1];
uint8_t buf[1024];
int len, size;
if (!s->connected || s->max_size <= 0)
return;
+
len = sizeof(buf);
if (len > s->max_size)
len = s->max_size;
- size = recv(s->fd, (void *)buf, len, 0);
+
+ iov[0].iov_base = buf;
+ iov[0].iov_len = len;
+
+ msg.msg_iov = iov;
+ msg.msg_iovlen = 1;
+
+ size = recvmsg(s->fd, &msg, 0);
if (size == 0) {
/* connection closed */
s->connected = 0;
--
1.6.2.5
next prev parent reply other threads:[~2009-07-06 17:31 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 17:30 [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors Mark McLoughlin
2009-07-06 17:30 ` Mark McLoughlin [this message]
2009-07-06 17:31 ` [Qemu-devel] [PATCH 2/3] Add SCM_RIGHTS support to unix socket character devices Mark McLoughlin
2009-07-06 17:32 ` [Qemu-devel] [PATCH 3/3] Add support for fd=msgfd for tap and socket networking Mark McLoughlin
2009-07-07 5:28 ` [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors Avi Kivity
2009-07-07 7:43 ` Mark McLoughlin
2009-07-07 7:52 ` Avi Kivity
2009-07-07 8:13 ` Mark McLoughlin
2009-07-07 9:03 ` Avi Kivity
2009-07-07 10:06 ` Daniel P. Berrange
2009-07-08 14:56 ` Mark McLoughlin
2009-07-08 14:57 ` [Qemu-devel] [PATCH 1/5] Make tcp_chr_read() use recvmsg() Mark McLoughlin
2009-07-08 14:57 ` [Qemu-devel] [PATCH 2/5] Add SCM_RIGHTS support to unix socket character devices Mark McLoughlin
2009-07-08 14:57 ` [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands Mark McLoughlin
2009-07-08 14:57 ` [Qemu-devel] [PATCH 4/5] Add monitor_get_fd() command for fetching named fds Mark McLoughlin
2009-07-08 14:57 ` [Qemu-devel] [PATCH 5/5] Add support for fd=name to tap and socket networking Mark McLoughlin
2009-07-08 15:26 ` [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands Avi Kivity
2009-07-08 16:03 ` Mark McLoughlin
2009-07-08 16:15 ` Avi Kivity
2009-07-08 18:08 ` Anthony Liguori
2009-07-08 18:11 ` Avi Kivity
2009-07-08 18:21 ` Anthony Liguori
2009-07-08 18:32 ` Avi Kivity
2009-07-08 18:50 ` Anthony Liguori
2009-07-08 19:52 ` Avi Kivity
2009-07-11 1:12 ` Jamie Lokier
2009-07-21 16:40 ` Mark McLoughlin
2009-07-21 16:53 ` [Qemu-devel] [PATCH] Make tcp_chr_read() use recvmsg() Mark McLoughlin
2009-07-21 17:13 ` Blue Swirl
2009-07-22 0:00 ` Jamie Lokier
2009-07-22 8:10 ` Mark McLoughlin
2009-07-22 8:11 ` [Qemu-devel] [PATCH 1/5] " Mark McLoughlin
2009-07-22 8:11 ` [Qemu-devel] [PATCH 2/5] Add SCM_RIGHTS support to unix socket character devices Mark McLoughlin
2009-08-13 16:20 ` Cam Macdonell
2009-08-14 6:38 ` Mark McLoughlin
2009-07-22 8:11 ` [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands Mark McLoughlin
2009-07-22 8:11 ` [Qemu-devel] [PATCH 4/5] Add monitor_get_fd() command for fetching named fds Mark McLoughlin
2009-07-22 8:11 ` [Qemu-devel] [PATCH 5/5] Add support for fd=name to tap and socket networking Mark McLoughlin
2009-07-23 13:37 ` Mark McLoughlin
2009-07-21 16:53 ` [Qemu-devel] [PATCH] Add SCM_RIGHTS support to unix socket character devices Mark McLoughlin
2009-07-21 16:53 ` [Qemu-devel] [PATCH] Add getfd and closefd monitor commands Mark McLoughlin
2009-07-21 16:53 ` [Qemu-devel] [PATCH] Add monitor_get_fd() command for fetching named fds Mark McLoughlin
2009-07-21 16:53 ` [Qemu-devel] [PATCH] Add support for fd=name to tap and socket networking Mark McLoughlin
2009-07-22 2:20 ` [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands Anthony Liguori
2009-07-22 8:09 ` Mark McLoughlin
2009-07-23 7:00 ` [Qemu-devel] " Jan Kiszka
2009-07-23 7:51 ` Mark McLoughlin
2009-07-08 15:25 ` [Qemu-devel] [PATCH 2/5] Add SCM_RIGHTS support to unix socket character devices Avi Kivity
2009-07-08 16:04 ` Mark McLoughlin
2009-07-08 16:17 ` Avi Kivity
2009-07-08 18:11 ` Anthony Liguori
2009-07-08 18:17 ` Avi Kivity
2009-07-11 1:15 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246901456.12086.21.camel@blaa \
--to=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).