From: Isaku Yamahata <yamahata@valinux.co.jp>
To: qemu-devel@nongnu.org
Cc: yamahata@valinux.co.jp
Subject: [Qemu-devel] [PATCH 3/6] pci: minor clean up of pci_update_mappings().
Date: Tue, 7 Jul 2009 15:59:24 +0900 [thread overview]
Message-ID: <1246949967-4778-4-git-send-email-yamahata@valinux.co.jp> (raw)
In-Reply-To: <1246949967-4778-1-git-send-email-yamahata@valinux.co.jp>
use uint8_t for pci command register instead of int.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
hw/pci.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 289a62f..7c7bab5 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -419,7 +419,8 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
static void pci_update_mappings(PCIDevice *d)
{
PCIIORegion *r;
- int cmd, i;
+ int i;
+ uint16_t cmd;
uint32_t last_addr, new_addr, config_ofs;
cmd = le16_to_cpu(*(uint16_t *)(d->config + PCI_COMMAND));
--
1.6.0.2
next prev parent reply other threads:[~2009-07-07 7:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 6:59 [Qemu-devel] [PATCH 0/6] pci: various clean up and 64bit bar support Isaku Yamahata
2009-07-07 6:59 ` [Qemu-devel] [PATCH 1/6] pci.c: remove unnecessary #ifdef DEBUG_PCI Isaku Yamahata
2009-07-07 6:59 ` [Qemu-devel] [PATCH 2/6] pci: use uint8_t for pci_register_bar() type argument of int Isaku Yamahata
2009-07-07 6:59 ` Isaku Yamahata [this message]
2009-07-07 6:59 ` [Qemu-devel] [PATCH 4/6] pci: define a constant to represent a unmapped bar and use it Isaku Yamahata
2009-07-07 6:59 ` [Qemu-devel] [PATCH 5/6] pci: use uint64_t for bar addr and size instead of uint32_t Isaku Yamahata
2009-07-07 6:59 ` [Qemu-devel] [PATCH 6/6] pci: 64bit bar support Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246949967-4778-4-git-send-email-yamahata@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).