Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors

[Mark McLoughlin <markmc@redhat.com>]

On Tue, 2009-07-07 at 10:52 +0300, Avi Kivity wrote:
> On 07/07/2009 10:43 AM, Mark McLoughlin wrote:
> >
> >>     (qemu) getfd foo
> >>     (qemu) getfd bar
> >>     (qemu) getfd baz
> >>     (qemu) pci_add ...,fd=foo
> >>     (qemu) pci_add ...,fd=bar ...,fd=baz
> >>
> >> A closefd command would be needed to deal with errors.
> >>      
> >
> > Nice idea, certainly.
> >
> > However, since it's only currently useful for tap/socket networking, I'm
> > happier with not adding two new monitor commands and only supporting a
> > single fd for now.
> >    
> 
> What happens when we do get more commands?

Any specific ideas around what else might use it?

> Do we then add the new commands and special-case fd=msgfd ?

Sounds like a fine plan to me. We could name an fd passed via the
current commands as "msgfd" and only the "getfd" command would have the
ability to assign another name.

Cheers,
Mark.