From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MO5nw-0003rf-Kz
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 04:13:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MO5nr-0003rP-W1
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 04:13:32 -0400
Received: from [199.232.76.173] (port=35474 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MO5nr-0003rM-Qg
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 04:13:27 -0400
Received: from mx2.redhat.com ([66.187.237.31]:60113)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MO5nr-0007wv-DI
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 04:13:27 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n678DQt8008500
	for <qemu-devel@nongnu.org>; Tue, 7 Jul 2009 04:13:26 -0400
Subject: Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command
	accept file descriptors
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <4A52FED7.4090800@redhat.com>
References: <1246901401.12086.20.camel@blaa> <4A52DD05.9030007@redhat.com>
	<1246952623.2836.13.camel@blaa>  <4A52FED7.4090800@redhat.com>
Content-Type: text/plain
Date: Tue, 07 Jul 2009 09:13:07 +0100
Message-Id: <1246954387.2836.30.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Tue, 2009-07-07 at 10:52 +0300, Avi Kivity wrote:
> On 07/07/2009 10:43 AM, Mark McLoughlin wrote:
> >
> >>     (qemu) getfd foo
> >>     (qemu) getfd bar
> >>     (qemu) getfd baz
> >>     (qemu) pci_add ...,fd=foo
> >>     (qemu) pci_add ...,fd=bar ...,fd=baz
> >>
> >> A closefd command would be needed to deal with errors.
> >>      
> >
> > Nice idea, certainly.
> >
> > However, since it's only currently useful for tap/socket networking, I'm
> > happier with not adding two new monitor commands and only supporting a
> > single fd for now.
> >    
> 
> What happens when we do get more commands?

Any specific ideas around what else might use it?

> Do we then add the new commands and special-case fd=msgfd ?

Sounds like a fine plan to me. We could name an fd passed via the
current commands as "msgfd" and only the "getfd" command would have the
ability to assign another name.

Cheers,
Mark.