From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOYlo-0006bg-0R
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:09:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOYlj-0006YY-1Y
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:09:15 -0400
Received: from [199.232.76.173] (port=51297 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOYli-0006YK-S1
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:09:10 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48575)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MOYli-0002gj-D3
	for qemu-devel@nongnu.org; Wed, 08 Jul 2009 11:09:10 -0400
Subject: Re: [Qemu-devel] [PATCH 3/3 v2] Add a pc-0-10 machine type for
	compatibility with 0.10.x
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <4A54A895.5090501@redhat.com>
References: <1244821292.30522.56.camel@blaa>
	<4A327E4A.7010300@codemonkey.ws>	<1244825303.26769.19.camel@blaa>
	<20090614095016.GA7560@redhat.com>	<1245056916.6891.31.camel@blaa>
	<4A3613EC.6030608@redhat.com>	<20090615103249.GB6351@redhat.com>
	<4A363012.8050409@redhat.com>	<20090615114858.GG6351@redhat.com>
	<4A3636FA.1040609@redhat.com>	<20090615124101.GH6351@redhat.com>
	<4A364381.401@redhat.com>	<4A364401.6010500@codemonkey.ws>
	<4A3647FB.9010808@redhat.com>	<4A364B53.9080007@codemonkey.ws>
	<4A364FE0.40204@redhat.com>	<4A3651EB.3070204@codemonkey.ws>
	<4A36555A.4090303@redhat.com>	<4A3659A0.3050108@codemonkey.ws>
	<4A366348.1030202@redhat.com>	<1245083229.3222.103.camel@blaa>
	<4A368F12.2090504@codemonkey.ws>	<1246964898.2836.38.camel@blaa>
	<1246964950.2836.39.camel@blaa>	<1246964998.2836.40.camel@blaa>
	<1246965054.2836.41.camel@blaa>	<4A5338FC.9030301@redhat.com>
	<1247049984.3270.52.camel@blaa>	<1247050083.3270.54.camel@blaa>
	<4A54986D.301@redhat.com> <4A54A2B0.6050605@codemonk! ey.ws>
	<4A54A895.5090501@redhat.com>
Content-Type: text/plain
Date: Wed, 08 Jul 2009 16:08:48 +0100
Message-Id: <1247065728.3270.65.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On Wed, 2009-07-08 at 16:09 +0200, Gerd Hoffmann wrote:
> On 07/08/09 15:44, Anthony Liguori wrote:
> > Gerd Hoffmann wrote:
> >>> +enum {
> >>> + COMPAT_DEFAULT = 0,
> >>> + COMPAT_0_10, /* compatible with qemu 0.10.x */
> >>> +};
> >>
> >> Hmm. Just digged in the virtio blk code. Noticed some ppc machines
> >> have virtio block devices too. So linking it to a machine type looks
> >> wrong to me.
> >
> > No, it's right. A machine type is nothing more than a default device
> > tree.
> 
> Plain "-M pc" has no virtio blk device.
> 
> > So basically, if we had device config files, it would look like:
> >
> > /usr/share/qemu/configs/pc-0-10.dts
> > /usr/share/qemu/configs/pc-0-11.dts
> > /usr/share/qemu/configs/pc -> /usr/share/qemu/configs/pc-0-11.dts
> 
> Doesn't work.  Your virtio blk device isn't in there.

Right - I had assumed Anthony meant that such a config file would also
have details on the defaults used for devices which can be added to that
machine.

Cheers,
Mark.