From: Stefan Weil <weil@mail.berlios.de>
To: Christoph Hellwig <hch@lst.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] qemu-iotests: fix pattern for write test
Date: Sat, 11 Jul 2009 14:34:56 +0200 [thread overview]
Message-ID: <1247315696-5877-1-git-send-email-weil@mail.berlios.de> (raw)
The write pattern value 0axb is invalid and evaluates to 0,
so the read check (which uses a correct value of 0xab) will fail.
This failure will only be detected with a separate patch for
qemu-io. Without it, qemu-io cannot interpret hex values
and always uses a pattern value of 0.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
002 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/002 b/002
index adbd85f..14025e2 100755
--- a/002
+++ b/002
@@ -61,7 +61,7 @@ $QEMU_IO -c "read -pP 0xa 0 $size" $TEST_IMG | _filter_qemu_io
echo
echo "unaligned pwrite"
-$QEMU_IO -c 'write -pP 0axb 66 42' $TEST_IMG | _filter_qemu_io
+$QEMU_IO -c 'write -pP 0xab 66 42' $TEST_IMG | _filter_qemu_io
echo
echo "verify pattern"
--
1.5.6.5
next reply other threads:[~2009-07-11 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 12:34 Stefan Weil [this message]
2009-07-11 12:35 ` [Qemu-devel] [PATCH] qemu-io: Fix parsing of pattern arguments Stefan Weil
2009-07-14 21:24 ` Christoph Hellwig
2009-07-14 21:29 ` Stefan Weil
2009-07-14 21:20 ` [Qemu-devel] [PATCH] qemu-iotests: fix pattern for write test Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247315696-5877-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).