From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MRLZ5-0007d0-LL
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 03:39:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MRLZ1-0007c1-T6
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 03:39:39 -0400
Received: from [199.232.76.173] (port=34645 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MRLZ1-0007by-NN
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 03:39:35 -0400
Received: from mx20.gnu.org ([199.232.41.8]:27794)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <linuxram@us.ibm.com>) id 1MRLZ1-0003iq-80
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 03:39:35 -0400
Received: from e37.co.us.ibm.com ([32.97.110.158])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <linuxram@us.ibm.com>) id 1MRLZ0-0004wg-BL
	for qemu-devel@nongnu.org; Thu, 16 Jul 2009 03:39:34 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e37.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6G7cgVZ025571
	for <qemu-devel@nongnu.org>; Thu, 16 Jul 2009 01:38:42 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n6G7dT3n239914
	for <qemu-devel@nongnu.org>; Thu, 16 Jul 2009 01:39:29 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n6G7dTNk030249
	for <qemu-devel@nongnu.org>; Thu, 16 Jul 2009 01:39:29 -0600
Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames
From: Ram Pai <linuxram@us.ibm.com>
In-Reply-To: <f43fc5580907150804l2d7efcb5k39f11dfa2f209f20@mail.gmail.com>
References: <1245862739.6278.7.camel@localhost>
	<1245998284.6278.99.camel@localhost> <4A447C8D.5000104@kevin-wolf.de>
	<1246063310.6278.115.camel@localhost>	
	<1246511321.6429.31.camel@localhost>
	<4A4C754D.10109@redhat.com>	 <4A4CAD86.9020607@us.ibm.com>
	<4A4CB39F.5070506@redhat.com>	 <1247041831.6297.12.camel@localhost>
	<1247644283.14246.3.camel@localhost>
	<f43fc5580907150804l2d7efcb5k39f11dfa2f209f20@mail.gmail.com>
Content-Type: text/plain
Date: Thu, 16 Jul 2009 00:39:27 -0700
Message-Id: <1247729967.14246.139.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: linuxram@us.ibm.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>

On Wed, 2009-07-15 at 18:04 +0300, Blue Swirl wrote:
> On 7/15/09, Ram Pai <linuxram@us.ibm.com> wrote:
> > Problem: It is impossible to feed filenames with the character colon because
> >  qemu interprets such names as a protocol. For example filename scsi:0, is
> >  interpreted as a protocol by name "scsi".
> 
> >  --- a/block/raw-posix.c
> >  +++ b/block/raw-posix.c
> >  +static int qemu_open(const char *filename, int flags, ...)
> 
> >  --- a/block/raw-win32.c
> >  +++ b/block/raw-win32.c
> >  +    fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
> 
> I bet this won't compile on win32.

yes. good catch. fix is in the next revision(rev 6). However I do not
have a setup to compile and test changes in win32-raw.c . I will have to
rely on somebody to do the testing. 

RP