qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Don't build option roms on Mac OS X
Date: Fri, 17 Jul 2009 15:12:48 +0200	[thread overview]
Message-ID: <1247836368-21369-1-git-send-email-agraf@suse.de> (raw)

Mac OS X ships with a pretty broken assembler, so it can't build
the multiboot option rom.

Let's disable option rom compilation for Mac OS X.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 configure |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/configure b/configure
index edabe8d..efded55 100755
--- a/configure
+++ b/configure
@@ -204,6 +204,7 @@ sdl="yes"
 sdl_x11="no"
 xen="yes"
 pkgversion=""
+broken_asm=""
 
 # OS specific
 if check_define __linux__ ; then
@@ -289,6 +290,8 @@ cocoa="yes"
 audio_drv_list="coreaudio"
 audio_possible_drivers="coreaudio sdl fmod"
 OS_LDFLAGS="-framework CoreFoundation -framework IOKit"
+# Mac OS X ships with an utterly broken assembler
+broken_asm=yes
 ;;
 SunOS)
     solaris="yes"
@@ -1827,6 +1830,12 @@ roms=
 if test "$cpu" = "i386" -o "$cpu" = "x86_64" ; then
   roms="pc-bios/optionrom"
 fi
+
+# Some systems (namely Mac OS X) have a broken assembler, so they
+# can't build option roms. Disable them for those.
+if test "$broken_asm" = "yes" ; then
+  roms=
+fi
 echo "ROMS=$roms" >> $config_host_mak
 
 if test -f ${config_host_h}~ ; then
-- 
1.6.0.2

             reply	other threads:[~2009-07-17 13:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 13:12 Alexander Graf [this message]
2009-07-17 14:36 ` [Qemu-devel] [PATCH] Don't build option roms on Mac OS X quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247836368-21369-1-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).