From: quintela@redhat.com
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH] Don't build option roms on Mac OS X
Date: Fri, 17 Jul 2009 16:36:35 +0200 [thread overview]
Message-ID: <1247841395-10556-1-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1247836368-21369-1-git-send-email-agraf@suse.de>
From: Juan Quintela <quintela@redhat.com>
Hi Alex
Do you mean to use this other patch?
It avoids the use of a new variable to achieve exactly the same
thing. I am cleaning up configure, and removing the not needed
variables.
Thanks, Juan.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
configure | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index ff241d9..6f8abb0 100755
--- a/configure
+++ b/configure
@@ -1831,8 +1831,10 @@ if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then
fi
echo "TOOLS=$tools" >> $config_host_mak
+# Mac OS X ships with a broken assembler
roms=
-if test "$cpu" = "i386" -o "$cpu" = "x86_64" ; then
+if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) -a \
+ "$targetos" != "Darwin" ; then
roms="pc-bios/optionrom"
fi
echo "ROMS=$roms" >> $config_host_mak
--
1.6.2.5
prev parent reply other threads:[~2009-07-17 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 13:12 [Qemu-devel] [PATCH] Don't build option roms on Mac OS X Alexander Graf
2009-07-17 14:36 ` quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247841395-10556-1-git-send-email-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).