From: Mark McLoughlin <markmc@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] notify io_thread at the end of rx handling
Date: Mon, 20 Jul 2009 19:15:46 +0100 [thread overview]
Message-ID: <1248113746.5654.128.camel@blaa> (raw)
In-Reply-To: <1248109661-1280-1-git-send-email-glommer@redhat.com>
On Mon, 2009-07-20 at 13:07 -0400, Glauber Costa wrote:
> This is a backport from qemu-kvm. Just instead of using kvm's specific
> notification mechanism, we use qemu_notify_event()
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
> hw/virtio-net.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio-net.c b/hw/virtio-net.c
> index 7a7eafe..218f985 100644
> --- a/hw/virtio-net.c
> +++ b/hw/virtio-net.c
> @@ -305,6 +305,10 @@ static void virtio_net_handle_rx(VirtIODevice *vdev, VirtQueue *vq)
> VirtIONet *n = to_virtio_net(vdev);
>
> qemu_flush_queued_packets(n->vc);
> +
> + /* We now have RX buffers, signal to the IO thread to break out of the
> + * select to re-poll the tap file descriptor */
> + qemu_notify_event();
> }
Looks good to me
Acked-by: Mark McLoughlin <markmc@redhat.com>
Cheers,
Mark.
prev parent reply other threads:[~2009-07-20 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 17:07 [Qemu-devel] [PATCH] notify io_thread at the end of rx handling Glauber Costa
2009-07-20 18:15 ` Mark McLoughlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248113746.5654.128.camel@blaa \
--to=markmc@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).