From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTePH-00021z-5J for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:11:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTePB-0001zb-Ux for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:11:02 -0400 Received: from [199.232.76.173] (port=51072 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTePB-0001zV-IZ for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:10:57 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:40349) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTePA-00050W-Kx for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:10:57 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n6MFrOi5031832 for ; Wed, 22 Jul 2009 11:53:24 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6MFx8tL253094 for ; Wed, 22 Jul 2009 11:59:08 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6MFx7UT000788 for ; Wed, 22 Jul 2009 11:59:07 -0400 Subject: Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct From: Hollis Blanchard In-Reply-To: <4A673180.4030108@codemonkey.ws> References: <1247831508-19023-1-git-send-email-agraf@suse.de> <1247831508-19023-2-git-send-email-agraf@suse.de> <1247831508-19023-3-git-send-email-agraf@suse.de> <1247831508-19023-4-git-send-email-agraf@suse.de> <4A673180.4030108@codemonkey.ws> Content-Type: text/plain Date: Wed, 22 Jul 2009 08:59:05 -0700 Message-Id: <1248278346.4521.5.camel@slab.beaverton.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Alexander Graf , qemu-devel@nongnu.org On Wed, 2009-07-22 at 10:34 -0500, Anthony Liguori wrote: > Alexander Graf wrote: > > Some generic code tries to access env->mp_state. Let's just make > > it happy and provide it. > > > > Signed-off-by: Alexander Graf > > > > Or we can move that code from kvm-all.c to target-i386/kvm.c where it > belongs :-) Common code uses mp_state, and i386 is the only thing calling that code. However, the ioctl used by that code is valid for all architectures; it will just return -EINVAL. Someday we might need it in common code, but then again it's not even clear to me it will be useful outside of x86. I'm fine with moving it too, as long as it's also renamed at the same time. :) -- Hollis Blanchard IBM Linux Technology Center