From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTee8-0001cp-Em for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:26:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTee3-0001be-I8 for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:26:23 -0400 Received: from [199.232.76.173] (port=50103 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTee3-0001bT-9B for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:26:19 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:32819) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTee2-0007sK-Hh for qemu-devel@nongnu.org; Wed, 22 Jul 2009 12:26:18 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e38.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n6MGMsfS024966 for ; Wed, 22 Jul 2009 10:22:54 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6MGQHXC213768 for ; Wed, 22 Jul 2009 10:26:17 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6MGQGZs006937 for ; Wed, 22 Jul 2009 10:26:16 -0600 Subject: Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct From: Hollis Blanchard In-Reply-To: <4A673CBE.8040003@codemonkey.ws> References: <1247831508-19023-1-git-send-email-agraf@suse.de> <1247831508-19023-2-git-send-email-agraf@suse.de> <1247831508-19023-3-git-send-email-agraf@suse.de> <1247831508-19023-4-git-send-email-agraf@suse.de> <4A673180.4030108@codemonkey.ws> <1248278346.4521.5.camel@slab.beaverton.ibm.com> <4A673CBE.8040003@codemonkey.ws> Content-Type: text/plain Date: Wed, 22 Jul 2009 09:26:14 -0700 Message-Id: <1248279975.16442.2.camel@slab.beaverton.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Alexander Graf , qemu-devel@nongnu.org On Wed, 2009-07-22 at 11:22 -0500, Anthony Liguori wrote: > Hollis Blanchard wrote: > > On Wed, 2009-07-22 at 10:34 -0500, Anthony Liguori wrote: > > > >> Alexander Graf wrote: > >> > >>> Some generic code tries to access env->mp_state. Let's just make > >>> it happy and provide it. > >>> > >>> Signed-off-by: Alexander Graf > >>> > >>> > >> Or we can move that code from kvm-all.c to target-i386/kvm.c where it > >> belongs :-) > >> > > > > Common code uses mp_state, and i386 is the only thing calling that code. > > However, the ioctl used by that code is valid for all architectures; it > > will just return -EINVAL. Someday we might need it in common code, but > > then again it's not even clear to me it will be useful outside of x86. > > > > I'm fine with moving it too, as long as it's also renamed at the same > > time. :) > > > > Why is it a common ioctl instead of an arch specific ioctl? I can only speculate: Marcelo probably thought other architectures may have something useful to put there. -- Hollis Blanchard IBM Linux Technology Center