From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTnFi-0002Om-IT for qemu-devel@nongnu.org; Wed, 22 Jul 2009 21:37:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTnFd-0002Lz-RV for qemu-devel@nongnu.org; Wed, 22 Jul 2009 21:37:46 -0400 Received: from [199.232.76.173] (port=33192 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTnFd-0002Lw-K3 for qemu-devel@nongnu.org; Wed, 22 Jul 2009 21:37:41 -0400 Received: from mail-pz0-f196.google.com ([209.85.222.196]:44340) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTnFc-0005s1-PW for qemu-devel@nongnu.org; Wed, 22 Jul 2009 21:37:41 -0400 Received: by pzk34 with SMTP id 34so372622pzk.4 for ; Wed, 22 Jul 2009 18:37:37 -0700 (PDT) From: Ed Swierk Content-Type: text/plain Date: Wed, 22 Jul 2009 18:37:34 -0700 Message-Id: <1248313054.14831.36.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] slirp: Remove our_addr code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Three problems with our_addr: - It's determined only once when qemu starts, but the address can change (just like the DNS configuration can). - It's supposed to be the IP address of a host network interface, but there's no guarantee that gethostbyname(gethostname()) actually does that: the host might be a laptop that has only a loopback interface up, or the hostname might be localhost.localdomain, etc. - It's useless: aside from the CU-SeeMe protocol emulation which I propose removing, the only other reference is in get_dns_addr(), but can't imagine why you would want to send DNS requests to a different IP address if you're running a DNS server on the host and resolv.conf points to 127.0.0.1. These problems are easily solved by removing the code. Signed-off-by: Ed Swierk --- diff --git a/slirp/main.h b/slirp/main.h index e87b068..8d09df9 100644 --- a/slirp/main.h +++ b/slirp/main.h @@ -30,7 +30,6 @@ extern char *slirp_tty; extern char *exec_shell; extern u_int curtime; extern fd_set *global_readfds, *global_writefds, *global_xfds; -extern struct in_addr our_addr; extern struct in_addr loopback_addr; extern char *username; extern char *socket_path; diff --git a/slirp/slirp.c b/slirp/slirp.c index 3214c29..aead5b0 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -26,8 +26,6 @@ #include "slirp.h" #include "hw/hw.h" -/* host address */ -struct in_addr our_addr; /* host loopback address */ struct in_addr loopback_addr; @@ -129,8 +127,6 @@ int get_dns_addr(struct in_addr *pdns_addr) if (sscanf(buff, "nameserver%*[ \t]%256s", buff2) == 1) { if (!inet_aton(buff2, &tmp_addr)) continue; - if (tmp_addr.s_addr == loopback_addr.s_addr) - tmp_addr = our_addr; /* If it's the first one, set it to dns_addr */ if (!found) { *pdns_addr = tmp_addr; @@ -164,8 +160,6 @@ int get_dns_addr(struct in_addr *pdns_addr) static void slirp_init_once(void) { static int initialized; - struct hostent *he; - char our_name[256]; #ifdef _WIN32 WSADATA Data; #endif @@ -181,17 +175,6 @@ static void slirp_init_once(void) #endif loopback_addr.s_addr = htonl(INADDR_LOOPBACK); - - /* FIXME: This address may change during runtime */ - if (gethostname(our_name, sizeof(our_name)) == 0) { - he = gethostbyname(our_name); - if (he) { - our_addr = *(struct in_addr *)he->h_addr; - } - } - if (our_addr.s_addr == 0) { - our_addr = loopback_addr; - } } static void slirp_state_save(QEMUFile *f, void *opaque);