[Qemu-devel] Re: [PATCH 3/5] Add getfd and closefd monitor commands

[Mark McLoughlin <markmc@redhat.com>]

On Thu, 2009-07-23 at 09:00 +0200, Jan Kiszka wrote:
> Mark McLoughlin wrote:
> > On Tue, 2009-07-21 at 21:20 -0500, Anthony Liguori wrote:
> >> Mark McLoughlin wrote:
> >>> My take on it is that we're all agreed that it's never valid with the
> >>> current monitor protocol for a client to queue up multiple fds. It's a
> >>> synchronous protocol, you can't send multiple commands at once.
> >>>   
> >> I think there's a subtle point that was lost in the thread.  While we'll 
> >> only need to queue one fd per MonitorState, we'll still need to deal 
> >> with multiple fds per CharDriverState.
> > 
> > Why? For a theoretical use case, or for the current monitor interface?
> > 
> 
> There can be multiple monitors attached at the same time, already today.

But each monitor has its own socket, CharDriverState and Monitor ...
multiple monitors is irrelevant to the need for an fd queue on
CharDriverState.

Cheers,
Mark.