From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUOFn-0001fV-J2 for qemu-devel@nongnu.org; Fri, 24 Jul 2009 13:08:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUOFi-0001de-DZ for qemu-devel@nongnu.org; Fri, 24 Jul 2009 13:08:19 -0400 Received: from [199.232.76.173] (port=33083 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUOFh-0001dG-Tb for qemu-devel@nongnu.org; Fri, 24 Jul 2009 13:08:13 -0400 Received: from cantor.suse.de ([195.135.220.2]:35505 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MUOFg-0000Ri-JF for qemu-devel@nongnu.org; Fri, 24 Jul 2009 13:08:13 -0400 From: Ulrich Hecht Date: Fri, 24 Jul 2009 19:10:32 +0200 Message-Id: <1248455432-12959-8-git-send-email-uli@suse.de> In-Reply-To: <1248455432-12959-7-git-send-email-uli@suse.de> References: <1248455432-12959-1-git-send-email-uli@suse.de> <1248455432-12959-2-git-send-email-uli@suse.de> <1248455432-12959-3-git-send-email-uli@suse.de> <1248455432-12959-4-git-send-email-uli@suse.de> <1248455432-12959-5-git-send-email-uli@suse.de> <1248455432-12959-6-git-send-email-uli@suse.de> <1248455432-12959-7-git-send-email-uli@suse.de> Subject: [Qemu-devel] [PATCH 7/7] linux-user: zero fstat buffer to initialize nsec fields List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi The fstat implementation does not initialize the nanosecond fields in the stat buffer; this caused funny values to turn up there, preventing, for instance, cp -p from preserving timestamps because utimensat rejected the out-of-bounds nanosecond values. Resetting the entire structure to zero fixes that. Signed-off-by: Ulrich Hecht --- linux-user/syscall.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2dc86ff..b413b08 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5523,6 +5523,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, if (!lock_user_struct(VERIFY_WRITE, target_st, arg2, 0)) goto efault; + memset(target_st, 0, sizeof(*target_st)); __put_user(st.st_dev, &target_st->st_dev); __put_user(st.st_ino, &target_st->st_ino); __put_user(st.st_mode, &target_st->st_mode); -- 1.6.2.1