From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH] fix broken migration
Date: Fri, 24 Jul 2009 16:20:23 -0400 [thread overview]
Message-ID: <1248466823-12707-1-git-send-email-glommer@redhat.com> (raw)
While fixing migration with -S, commit
89befdd1a6b18215153b8976682d57b7d03d5782 broke the rest of us. Poor
glommer, with a poor family, spare him his life from this monstruosity.
Since the unconditional vm_start, not autostart was the villain, I'm putting
back autostart. Let me know if you prefer other solutions, it doesn't really matter,
doesn't really matter to me.
Any way the wind blows...
Signed-off-by: Glauber Costa <glommer@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
---
vl.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index ce213c2..015f631 100644
--- a/vl.c
+++ b/vl.c
@@ -6075,8 +6075,10 @@ int main(int argc, char **argv, char **envp)
if (loadvm)
do_loadvm(cur_mon, loadvm);
- if (incoming)
+ if (incoming) {
+ autostart = 0;
qemu_start_incoming_migration(incoming);
+ }
if (autostart)
vm_start();
--
1.6.2.2
next reply other threads:[~2009-07-24 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 20:20 Glauber Costa [this message]
2009-07-25 1:37 ` [Qemu-devel] Re: [PATCH] fix broken migration Paolo Bonzini
2009-07-27 18:02 ` Glauber Costa
2009-07-27 19:31 ` Paolo Bonzini
2009-07-27 20:18 ` Glauber Costa
2009-07-27 21:08 ` [Qemu-devel] [PATCH] fix migration to not require -S Paolo Bonzini
2009-07-27 21:17 ` [Qemu-devel] [PATCH alternative] fix migration to obey -S Paolo Bonzini
2009-07-27 21:29 ` [Qemu-devel] " Glauber Costa
2009-07-27 21:36 ` Anthony Liguori
2009-07-27 23:15 ` Glauber Costa
2009-07-27 23:13 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248466823-12707-1-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).