qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary
Date: Sat, 25 Jul 2009 01:16:45 +0200	[thread overview]
Message-ID: <1248477406-50728-4-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1248477406-50728-3-git-send-email-agraf@suse.de>

When giving KVM a slot of a size not on page boundary, it chokes. So let's
just round up the VGA BIOS size so nobody complains anymore and we don't need
to implement sub-page slots.

Required for booting a PPC guest in KVM.

Signed-off-by: Alexander Graf <agraf@suse.de>

---

V2 removes a left over debug message
---
 hw/ppc_newworld.c |    3 +++
 hw/ppc_oldworld.c |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c
index 4e5043c..b28a23d 100644
--- a/hw/ppc_newworld.c
+++ b/hw/ppc_newworld.c
@@ -179,6 +179,9 @@ static void ppc_core99_init (ram_addr_t ram_size,
         vga_bios_ptr[3] = 'V';
         cpu_to_be32w((uint32_t *)(vga_bios_ptr + 4), vga_bios_size);
         vga_bios_size += 8;
+
+        /* Round to page boundary */
+        vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) & TARGET_PAGE_MASK;
     }
 
     if (linux_boot) {
diff --git a/hw/ppc_oldworld.c b/hw/ppc_oldworld.c
index b26e407..0bd6376 100644
--- a/hw/ppc_oldworld.c
+++ b/hw/ppc_oldworld.c
@@ -212,6 +212,9 @@ static void ppc_heathrow_init (ram_addr_t ram_size,
         vga_bios_ptr[3] = 'V';
         cpu_to_be32w((uint32_t *)(vga_bios_ptr + 4), vga_bios_size);
         vga_bios_size += 8;
+
+        /* Round to page boundary */
+        vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) & TARGET_PAGE_MASK;
     }
 
     if (linux_boot) {
-- 
1.6.0.2

  reply	other threads:[~2009-07-24 23:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 23:16 [Qemu-devel] [PATCH 0/4] PPC KVM bringup patches round 2 v2 Alexander Graf
2009-07-24 23:16 ` [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON Alexander Graf
2009-07-24 23:16   ` [Qemu-devel] [PATCH 2/4] Use 64bit pointer for dirty log Alexander Graf
2009-07-24 23:16     ` Alexander Graf [this message]
2009-07-24 23:16       ` [Qemu-devel] [PATCH 4/4] Give the kernel more room Alexander Graf
2009-07-25 17:15       ` [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary Blue Swirl
2009-07-25 18:12         ` Alexander Graf
2009-07-27  7:22           ` Blue Swirl
2009-07-27 13:51   ` [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON Anthony Liguori
2009-07-27 13:56     ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248477406-50728-4-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).