qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH] fix endless look at kvm migration
Date: Mon, 27 Jul 2009 14:26:42 -0400	[thread overview]
Message-ID: <1248719202-24401-1-git-send-email-glommer@redhat.com> (raw)

If we try to sync bitmaps withouth KVM_MEM_LOG_DIRTY_PAGES being set
on a slot, we will enter an endless loop. Remove the test, since it
is not strictly needed anyway

Signed-off-by: Glauber Costa <glommer@redhat.com>
CC: Alexander Graf <agraf@suse.de>
---
 kvm-all.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index 824bb4c..d3bbd3c 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -331,11 +331,6 @@ int kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
             break;
         }
 
-        /* We didn't activate dirty logging? Don't care then. */
-        if(!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES)) {
-            continue;
-        }
-
         size = ((mem->memory_size >> TARGET_PAGE_BITS) + 7) / 8;
         if (!d.dirty_bitmap) {
             d.dirty_bitmap = qemu_malloc(size);
-- 
1.6.2.2

             reply	other threads:[~2009-07-27 18:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27 18:26 Glauber Costa [this message]
2009-07-27 18:41 ` [Qemu-devel] Re: [PATCH] fix endless look at kvm migration Alexander Graf
2009-07-27 18:44 ` Jan Kiszka
2009-07-27 18:47   ` Alexander Graf
2009-07-27 18:52     ` Jan Kiszka
2009-07-27 20:21   ` Glauber Costa
2009-07-27 20:22     ` Luiz Capitulino
2009-07-27 20:36       ` Glauber Costa
2009-07-27 20:31         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248719202-24401-1-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).