From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVUuR-0007Rn-Ig for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:26:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVUuM-0007Oy-Lg for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:26:50 -0400 Received: from [199.232.76.173] (port=47659 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVUuM-0007Or-Gj for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:26:46 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58970) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVUuL-0000F0-4T for qemu-devel@nongnu.org; Mon, 27 Jul 2009 14:26:45 -0400 From: Glauber Costa Date: Mon, 27 Jul 2009 14:26:42 -0400 Message-Id: <1248719202-24401-1-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH] fix endless look at kvm migration List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, Alexander Graf If we try to sync bitmaps withouth KVM_MEM_LOG_DIRTY_PAGES being set on a slot, we will enter an endless loop. Remove the test, since it is not strictly needed anyway Signed-off-by: Glauber Costa CC: Alexander Graf --- kvm-all.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 824bb4c..d3bbd3c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -331,11 +331,6 @@ int kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr, break; } - /* We didn't activate dirty logging? Don't care then. */ - if(!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES)) { - continue; - } - size = ((mem->memory_size >> TARGET_PAGE_BITS) + 7) / 8; if (!d.dirty_bitmap) { d.dirty_bitmap = qemu_malloc(size); -- 1.6.2.2