qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH] fix migration to not require -S
Date: Mon, 27 Jul 2009 23:08:35 +0200	[thread overview]
Message-ID: <1248728915-4984-1-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <20090727201855.GK4776@poweredge.glommer>

Since migration returns right away, starting the VM right
after calling qemu_start_incoming_migration is wrong even
if -S is not passed.

Cc: Glauber Costa  <glommer@redhat.com>
Cc: Anthony Liguori  <aliguori@us.ibm.com>
---
	Oh my gosh.  This is what I have in my tree and I did not squash
	it before sending out the patch to the list.  I guess that this
	monstrosity :-) explains my reaction to Glauber's patch.

	Anthony, I don't care if you apply my patch or his.

 vl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/vl.c b/vl.c
index 845d185..d826968 100644
--- a/vl.c
+++ b/vl.c
@@ -6198,7 +6198,7 @@ int main(int argc, char **argv, char **envp)
     if (incoming)
         qemu_start_incoming_migration(incoming);
 
-    if (autostart)
+    else if (autostart)
         vm_start();
 
 #ifndef _WIN32
-- 
1.6.2.5

  reply	other threads:[~2009-07-27 21:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 20:20 [Qemu-devel] [PATCH] fix broken migration Glauber Costa
2009-07-25  1:37 ` [Qemu-devel] " Paolo Bonzini
2009-07-27 18:02   ` Glauber Costa
2009-07-27 19:31     ` Paolo Bonzini
2009-07-27 20:18       ` Glauber Costa
2009-07-27 21:08         ` Paolo Bonzini [this message]
2009-07-27 21:17         ` [Qemu-devel] [PATCH alternative] fix migration to obey -S Paolo Bonzini
2009-07-27 21:29           ` [Qemu-devel] " Glauber Costa
2009-07-27 21:36             ` Anthony Liguori
2009-07-27 23:15               ` Glauber Costa
2009-07-27 23:13                 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248728915-4984-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=glommer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).