From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com,
avi@redhat.com, Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH 09/25] monitor: Port handler_0 to use the dictionary
Date: Tue, 28 Jul 2009 19:04:57 -0300 [thread overview]
Message-ID: <1248818713-11261-10-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com>
This commit ports command handlers that receive no arguments to use
the new monitor's dictionary.
It might seem no sense to do this, as the handlers have no arguments,
but at the end of this porting work all handlers will have the same
structure.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
migration.c | 2 +-
migration.h | 3 ++-
monitor.c | 18 +++++++++---------
3 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/migration.c b/migration.c
index ee64d41..024793f 100644
--- a/migration.c
+++ b/migration.c
@@ -72,7 +72,7 @@ void do_migrate(Monitor *mon, int detach, const char *uri)
}
}
-void do_migrate_cancel(Monitor *mon)
+void do_migrate_cancel(Monitor *mon, const struct qemu_dict *qdict)
{
MigrationState *s = current_migration;
diff --git a/migration.h b/migration.h
index 37c7f8e..97c0044 100644
--- a/migration.h
+++ b/migration.h
@@ -15,6 +15,7 @@
#define QEMU_MIGRATION_H
#include "qemu-common.h"
+#include "qemu-dict.h"
#define MIG_STATE_ERROR -1
#define MIG_STATE_COMPLETED 0
@@ -51,7 +52,7 @@ void qemu_start_incoming_migration(const char *uri);
void do_migrate(Monitor *mon, int detach, const char *uri);
-void do_migrate_cancel(Monitor *mon);
+void do_migrate_cancel(Monitor *mon, const struct qemu_dict *qdict);
void do_migrate_set_speed(Monitor *mon, const char *value);
diff --git a/monitor.c b/monitor.c
index b46df28..46b3e0c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -426,7 +426,7 @@ static void do_info_cpu_stats(Monitor *mon)
}
#endif
-static void do_quit(Monitor *mon)
+static void do_quit(Monitor *mon, const struct qemu_dict *qdict)
{
exit(0);
}
@@ -559,7 +559,7 @@ static void do_singlestep(Monitor *mon, const char *option)
}
}
-static void do_stop(Monitor *mon)
+static void do_stop(Monitor *mon, const struct qemu_dict *qdict)
{
vm_stop(EXCP_INTERRUPT);
}
@@ -571,7 +571,7 @@ struct bdrv_iterate_context {
int err;
};
-static void do_cont(Monitor *mon)
+static void do_cont(Monitor *mon, const struct qemu_dict *qdict)
{
struct bdrv_iterate_context context = { mon, 0 };
@@ -587,7 +587,7 @@ static void bdrv_key_cb(void *opaque, int err)
/* another key was set successfully, retry to continue */
if (!err)
- do_cont(mon);
+ do_cont(mon, NULL);
}
static void encrypted_bdrv_it(void *opaque, BlockDriverState *bs)
@@ -1246,12 +1246,12 @@ static void do_boot_set(Monitor *mon, const char *bootdevice)
}
}
-static void do_system_reset(Monitor *mon)
+static void do_system_reset(Monitor *mon, const struct qemu_dict *qdict)
{
qemu_system_reset_request();
}
-static void do_system_powerdown(Monitor *mon)
+static void do_system_powerdown(Monitor *mon, const struct qemu_dict *qdict)
{
qemu_system_powerdown_request();
}
@@ -2638,7 +2638,7 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline)
void *str_allocated[MAX_ARGS];
void *args[MAX_ARGS];
struct qemu_dict *qdict;
- void (*handler_0)(Monitor *mon);
+ void (*handler_d)(Monitor *mon, const struct qemu_dict *qdict);
void (*handler_1)(Monitor *mon, void *arg0);
void (*handler_2)(Monitor *mon, void *arg0, void *arg1);
void (*handler_3)(Monitor *mon, void *arg0, void *arg1, void *arg2);
@@ -2940,8 +2940,8 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline)
switch(nb_args) {
case 0:
- handler_0 = cmd->handler;
- handler_0(mon);
+ handler_d = cmd->handler;
+ handler_d(mon, qdict);
break;
case 1:
handler_1 = cmd->handler;
--
1.6.4.rc3.12.gdf73a
next prev parent reply other threads:[~2009-07-28 22:06 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 22:04 [Qemu-devel] [PATCH 00/25] Monitor handlers new structure phase 1 Luiz Capitulino
2009-07-28 22:04 ` [Qemu-devel] [PATCH 01/25] Introduce QEMU dictionary data type Luiz Capitulino
2009-07-28 22:39 ` malc
2009-07-29 13:28 ` Luiz Capitulino
2009-07-29 13:38 ` malc
2009-07-29 13:38 ` Avi Kivity
2009-07-29 15:23 ` [Qemu-devel] " Paolo Bonzini
2009-07-29 15:24 ` Paolo Bonzini
2009-07-29 9:47 ` Avi Kivity
2009-07-29 9:49 ` Avi Kivity
2009-07-29 10:42 ` François Revol
2009-07-29 13:28 ` Anthony Liguori
2009-07-29 14:05 ` Avi Kivity
2009-07-29 13:46 ` Luiz Capitulino
2009-07-29 13:57 ` Avi Kivity
2009-07-29 14:22 ` Luiz Capitulino
2009-07-29 14:37 ` Avi Kivity
2009-07-29 16:11 ` Luiz Capitulino
2009-07-29 16:19 ` Avi Kivity
2009-07-30 14:50 ` Luiz Capitulino
2009-07-30 15:03 ` Avi Kivity
2009-07-30 15:05 ` Luiz Capitulino
2009-07-30 15:04 ` Filip Navara
2009-07-30 15:13 ` Avi Kivity
2009-07-30 15:15 ` Filip Navara
2009-07-30 15:19 ` Paul Brook
2009-07-28 22:04 ` [Qemu-devel] [PATCH 02/25] net: Fix do_set_link() return type Luiz Capitulino
2009-07-28 22:04 ` [Qemu-devel] [PATCH 03/25] Add wrappers to functions used by the Monitor Luiz Capitulino
2009-07-28 22:04 ` [Qemu-devel] [PATCH 04/25] monitor: Document missing supported argument types Luiz Capitulino
2009-07-28 22:04 ` [Qemu-devel] [PATCH 05/25] monitor: New format for handlers " Luiz Capitulino
2009-07-28 22:04 ` [Qemu-devel] [PATCH 06/25] monitor: Setup a dictionary with handler arguments Luiz Capitulino
2009-07-28 22:04 ` [Qemu-devel] [PATCH 07/25] monitor: Export qemu-dict.h header Luiz Capitulino
2009-07-28 22:04 ` [Qemu-devel] [PATCH 08/25] monitor: New GET_TLONG and GET_TPHYSADDR macros Luiz Capitulino
2009-07-28 22:04 ` Luiz Capitulino [this message]
2009-07-28 22:04 ` [Qemu-devel] [PATCH 10/25] monitor: Port handler_1 to use the dictionary Luiz Capitulino
2009-07-28 22:04 ` [Qemu-devel] [PATCH 11/25] monitor: Port handler_2 " Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 12/25] monitor: Port handler_3 " Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 13/25] monitor: Port handler_4 " Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 14/25] monitor: Port handler_5 " Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 15/25] monitor: Port handler_6 " Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 16/25] monitor: Port handler_7 " Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 17/25] monitor: Drop handler_8 and handler_9 handling Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 18/25] monitor: Port handler_10 to use the dictionary Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 19/25] monitor: Split monitor_handle_command() Luiz Capitulino
2009-07-29 15:31 ` [Qemu-devel] " Paolo Bonzini
2009-07-29 15:44 ` Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 20/25] monitor: Add a new index for str_allocated[] Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 21/25] monitor: Drop args[] from monitor_parse_command() Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 22/25] monitor: Drop 'nb_args' " Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 23/25] Add check support Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 24/25] Introduce dictionary test data file Luiz Capitulino
2009-07-28 22:05 ` [Qemu-devel] [PATCH 25/25] Introduce qemu-dict unit-tests Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2009-08-03 16:56 [Qemu-devel] [PATCH v1 00/25] Monitor handlers new structure phase 1 Luiz Capitulino
2009-08-03 16:57 ` [Qemu-devel] [PATCH 09/25] monitor: Port handler_0 to use the dictionary Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248818713-11261-10-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=dlaor@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).