From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVuob-0000kb-Bs for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:06:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVuoW-0000d4-Es for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:06:32 -0400 Received: from [199.232.76.173] (port=49652 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVuoW-0000ci-5B for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:06:28 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37521) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVuoV-0000Zm-GN for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:06:27 -0400 From: Luiz Capitulino Date: Tue, 28 Jul 2009 19:05:00 -0300 Message-Id: <1248818713-11261-13-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com> References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 12/25] monitor: Port handler_3 to use the dictionary List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com, avi@redhat.com, Luiz Capitulino This commit ports command handlers that receive three arguments to use the new monitor's dictionary. Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c | 6 ++++-- monitor.c | 24 +++++++++++++----------- net.c | 12 ++++++++---- net.h | 6 ++---- sysemu.h | 3 +-- 5 files changed, 28 insertions(+), 23 deletions(-) diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c index 07d240f..d3fb232 100644 --- a/hw/pci-hotplug.c +++ b/hw/pci-hotplug.c @@ -147,10 +147,12 @@ static PCIDevice *qemu_pci_hot_add_storage(Monitor *mon, return dev; } -void pci_device_hot_add(Monitor *mon, const char *pci_addr, const char *type, - const char *opts) +void pci_device_hot_add(Monitor *mon, const struct qemu_dict *qdict) { PCIDevice *dev = NULL; + const char *pci_addr = qemu_dict_get(qdict, "pci_addr"); + const char *type = qemu_dict_get(qdict, "type"); + const char *opts = qemu_dict_get(qdict, "opts"); /* strip legacy tag */ if (!strncmp(pci_addr, "pci_addr=", 9)) { diff --git a/monitor.c b/monitor.c index 1937837..07fc14a 100644 --- a/monitor.c +++ b/monitor.c @@ -517,9 +517,11 @@ static void do_change_vnc(Monitor *mon, const char *target, const char *arg) } } -static void do_change(Monitor *mon, const char *device, const char *target, - const char *arg) +static void do_change(Monitor *mon, const struct qemu_dict *qdict) { + const char *device = qemu_dict_get(qdict, "device"); + const char *target = qemu_dict_get(qdict, "target"); + const char *arg = qemu_dict_get(qdict, "arg"); if (strcmp(device, "vnc") == 0) { do_change_vnc(mon, target, arg); } else { @@ -1120,12 +1122,14 @@ static void release_keys(void *opaque) } } -static void do_sendkey(Monitor *mon, const char *string, int has_hold_time, - int hold_time) +static void do_sendkey(Monitor *mon, const struct qemu_dict *qdict) { char keyname_buf[16]; char *separator; int keyname_len, keycode, i; + const char *string = qemu_dict_get(qdict, "string"); + int has_hold_time = qemu_dict_exists(qdict, "hold_time"); + long hold_time = (long) qemu_dict_get(qdict, "hold_time"); if (nb_pending_keycodes > 0) { qemu_del_timer(key_timer); @@ -1174,10 +1178,12 @@ static void do_sendkey(Monitor *mon, const char *string, int has_hold_time, static int mouse_button_state; -static void do_mouse_move(Monitor *mon, const char *dx_str, const char *dy_str, - const char *dz_str) +static void do_mouse_move(Monitor *mon, const struct qemu_dict *qdict) { int dx, dy, dz; + const char *dx_str = qemu_dict_get(qdict, "dx_str"); + const char *dy_str = qemu_dict_get(qdict, "dy_str"); + const char *dz_str = qemu_dict_get(qdict, "dz_str"); dx = strtol(dx_str, NULL, 0); dy = strtol(dy_str, NULL, 0); dz = 0; @@ -2662,7 +2668,6 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) void *args[MAX_ARGS]; struct qemu_dict *qdict; void (*handler_d)(Monitor *mon, const struct qemu_dict *qdict); - void (*handler_3)(Monitor *mon, void *arg0, void *arg1, void *arg2); void (*handler_4)(Monitor *mon, void *arg0, void *arg1, void *arg2, void *arg3); void (*handler_5)(Monitor *mon, void *arg0, void *arg1, void *arg2, @@ -2963,13 +2968,10 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) case 0: case 1: case 2: + case 3: handler_d = cmd->handler; handler_d(mon, qdict); break; - case 3: - handler_3 = cmd->handler; - handler_3(mon, args[0], args[1], args[2]); - break; case 4: handler_4 = cmd->handler; handler_4(mon, args[0], args[1], args[2], args[3]); diff --git a/net.c b/net.c index 2fedd13..e260efa 100644 --- a/net.c +++ b/net.c @@ -903,8 +903,7 @@ static SlirpState *slirp_lookup(Monitor *mon, const char *vlan, } } -void net_slirp_hostfwd_remove(Monitor *mon, const char *arg1, - const char *arg2, const char *arg3) +void net_slirp_hostfwd_remove(Monitor *mon, const struct qemu_dict *qdict) { struct in_addr host_addr = { .s_addr = INADDR_ANY }; int host_port; @@ -913,6 +912,9 @@ void net_slirp_hostfwd_remove(Monitor *mon, const char *arg1, SlirpState *s; int is_udp = 0; int err; + const char *arg1 = qemu_dict_get(qdict, "arg1"); + const char *arg2 = qemu_dict_get(qdict, "arg2"); + const char *arg3 = qemu_dict_get(qdict, "arg3"); if (arg2) { s = slirp_lookup(mon, arg1, arg2); @@ -1022,11 +1024,13 @@ static void slirp_hostfwd(SlirpState *s, Monitor *mon, const char *redir_str, config_error(mon, "invalid host forwarding rule '%s'\n", redir_str); } -void net_slirp_hostfwd_add(Monitor *mon, const char *arg1, - const char *arg2, const char *arg3) +void net_slirp_hostfwd_add(Monitor *mon, const struct qemu_dict *qdict) { const char *redir_str; SlirpState *s; + const char *arg1 = qemu_dict_get(qdict, "arg1"); + const char *arg2 = qemu_dict_get(qdict, "arg2"); + const char *arg3 = qemu_dict_get(qdict, "arg3"); if (arg2) { s = slirp_lookup(mon, arg1, arg2); diff --git a/net.h b/net.h index e982868..8cc5e64 100644 --- a/net.h +++ b/net.h @@ -137,10 +137,8 @@ int net_client_init(Monitor *mon, const char *device, const char *p); void net_client_uninit(NICInfo *nd); int net_client_parse(const char *str); void net_slirp_smb(const char *exported_dir); -void net_slirp_hostfwd_add(Monitor *mon, const char *arg1, - const char *arg2, const char *arg3); -void net_slirp_hostfwd_remove(Monitor *mon, const char *arg1, - const char *arg2, const char *arg3); +void net_slirp_hostfwd_add(Monitor *mon, const struct qemu_dict *qdict); +void net_slirp_hostfwd_remove(Monitor *mon, const struct qemu_dict *qdict); void net_slirp_redir(const char *redir_str); void net_cleanup(void); void net_client_check(void); diff --git a/sysemu.h b/sysemu.h index 730cc1e..86dee65 100644 --- a/sysemu.h +++ b/sysemu.h @@ -209,8 +209,7 @@ void destroy_nic(dev_match_fn *match_fn, void *arg); void destroy_bdrvs(dev_match_fn *match_fn, void *arg); /* pci-hotplug */ -void pci_device_hot_add(Monitor *mon, const char *pci_addr, const char *type, - const char *opts); +void pci_device_hot_add(Monitor *mon, const struct qemu_dict *qdict); void drive_hot_add(Monitor *mon, const struct qemu_dict *qdict); void pci_device_hot_remove(Monitor *mon, const char *pci_addr); void do_pci_device_hot_remove(Monitor *mon, const struct qemu_dict *qdict); -- 1.6.4.rc3.12.gdf73a