From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVuoH-0000E0-Rx for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:06:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVuoC-0008Ul-Qx for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:06:13 -0400 Received: from [199.232.76.173] (port=49635 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVuoC-0008UH-NA for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:06:08 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37483) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVuoC-0000VM-6R for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:06:08 -0400 From: Luiz Capitulino Date: Tue, 28 Jul 2009 19:04:50 -0300 Message-Id: <1248818713-11261-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com> References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 02/25] net: Fix do_set_link() return type List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, dlaor@redhat.com, avi@redhat.com, Luiz Capitulino do_set_link() returns int, but Monitor handler functions should always return void. Signed-off-by: Luiz Capitulino --- net.c | 6 ++---- net.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/net.c b/net.c index b5e8c9f..1b531e7 100644 --- a/net.c +++ b/net.c @@ -2905,7 +2905,7 @@ void do_info_network(Monitor *mon) } } -int do_set_link(Monitor *mon, const char *name, const char *up_or_down) +void do_set_link(Monitor *mon, const char *name, const char *up_or_down) { VLANState *vlan; VLANClientState *vc = NULL; @@ -2918,7 +2918,7 @@ done: if (!vc) { monitor_printf(mon, "could not find network device '%s'", name); - return 0; + return; } if (strcmp(up_or_down, "up") == 0) @@ -2931,8 +2931,6 @@ done: if (vc->link_status_changed) vc->link_status_changed(vc); - - return 1; } void net_cleanup(void) diff --git a/net.h b/net.h index 188fa39..3ac9e8c 100644 --- a/net.h +++ b/net.h @@ -79,7 +79,7 @@ void qemu_check_nic_model_list(NICInfo *nd, const char * const *models, void qemu_handler_true(void *opaque); void do_info_network(Monitor *mon); -int do_set_link(Monitor *mon, const char *name, const char *up_or_down); +void do_set_link(Monitor *mon, const char *name, const char *up_or_down); void do_info_usernet(Monitor *mon); -- 1.6.4.rc3.12.gdf73a