From: Alexandre Bique <alexandre.bique@citrix.com>
To: qemu-devel@nongnu.org
Cc: Alexandre Bique <alexandre.bique@citrix.com>
Subject: [Qemu-devel] [PATCH 1/7] atapi: fix up a few comments
Date: Fri, 7 Aug 2009 18:33:06 +0100 [thread overview]
Message-ID: <1249666392-31905-2-git-send-email-alexandre.bique@citrix.com> (raw)
In-Reply-To: <1249666392-31905-1-git-send-email-alexandre.bique@citrix.com>
Signed-off-by: Alexandre Bique <alexandre.bique@citrix.com>
---
hw/ide.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/ide.c b/hw/ide.c
index 6cf04a6..e4e2ab7 100644
--- a/hw/ide.c
+++ b/hw/ide.c
@@ -1680,9 +1680,9 @@ static void ide_atapi_cmd(IDEState *s)
switch(action) {
case 0: /* current values */
switch(code) {
- case 0x01: /* error recovery */
+ case 0x01: /* read write error recovery parameters */
cpu_to_ube16(&buf[0], 16 + 6);
- buf[2] = 0x70;
+ buf[2] = 0x70; /* Obsolete: medium type code */
buf[3] = 0;
buf[4] = 0;
buf[5] = 0;
@@ -1699,17 +1699,17 @@ static void ide_atapi_cmd(IDEState *s)
buf[15] = 0x00;
ide_atapi_cmd_reply(s, 16, max_len);
break;
- case 0x2a:
+ case 0x2a: /* CD/DVD capabilities & mechanical status */
cpu_to_ube16(&buf[0], 28 + 6);
- buf[2] = 0x70;
+ buf[2] = 0x70; /* Obsolete: medium type code */
buf[3] = 0;
buf[4] = 0;
buf[5] = 0;
buf[6] = 0;
buf[7] = 0;
- buf[8] = 0x2a;
- buf[9] = 0x12;
+ buf[8] = 0x2a; /* page code */
+ buf[9] = 0x12; /* page length */
buf[10] = 0x00;
buf[11] = 0x00;
--
1.6.4
next prev parent reply other threads:[~2009-08-07 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 17:33 [Qemu-devel] ATAPI pass throug v4 Alexandre Bique
2009-08-07 17:33 ` Alexandre Bique [this message]
2009-08-07 17:33 ` [Qemu-devel] [PATCH 2/7] atapi: protocol define updates Alexandre Bique
2009-08-07 17:33 ` [Qemu-devel] [PATCH 3/7] atapi: guessing if the cdrom device is a scsi device Alexandre Bique
2009-08-07 17:33 ` [Qemu-devel] [PATCH 4/7] atapi: adds header guards to hw/pcmia.h Alexandre Bique
2009-08-07 17:33 ` [Qemu-devel] [PATCH 5/7] atapi: adds header guards to hw/mac_dbdma.h Alexandre Bique
2009-08-07 17:33 ` [Qemu-devel] [PATCH 6/7] atapi: made some part of ide.c public and moved some part to atapi Alexandre Bique
2009-08-07 17:33 ` [Qemu-devel] [PATCH 7/7] atapi: introducing atapi pass through Alexandre Bique
2009-08-10 20:09 ` [Qemu-devel] ATAPI pass throug v4 Anthony Liguori
[not found] <<19074.63829.151234.423348@mariner.uk.xensource.com>
2009-08-11 15:35 ` [Qemu-devel] [PATCH 1/7] atapi: fix up a few comments Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249666392-31905-2-git-send-email-alexandre.bique@citrix.com \
--to=alexandre.bique@citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).